Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move windows troubleshooting 1.24 #31899

Closed
wants to merge 1 commit into from
Closed

Move windows troubleshooting 1.24 #31899

wants to merge 1 commit into from

Conversation

marosset
Copy link
Contributor

Part of #31428

/label refactor
/sig windows

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Feb 25, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/windows Categorizes an issue or PR as relevant to SIG Windows. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2022
@netlify
Copy link

netlify bot commented Feb 25, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 534c45f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6245f54c14b9d00009a29543

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 25, 2022
@marosset marosset mentioned this pull request Feb 25, 2022
Open
31 tasks
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 25, 2022
@jihoon-seo jihoon-seo mentioned this pull request Feb 25, 2022
Closed
@tengqm
Copy link
Contributor

tengqm commented Mar 25, 2022

@marosset Is this still a WIP?
LGTM other than some nits.

shannonxtreme
shannonxtreme approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@shannonxtreme shannonxtreme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of the nits

content/en/docs/setup/production-environment/windows/intro-windows-in-kubernetes.md
@@ -715,268 +715,15 @@ troubleshooting assistance from other contributors. Follow the
instructions in the
SIG Windows [contributing guide on gathering logs](https://github.com/kubernetes/community/blob/master/sig-windows/CONTRIBUTING.md#gathering-logs).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a link to the new page from here, under "Troubleshooting your Windows clusters" or similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to point to /docs/tasks/debug-application-cluster/ so people can find the new Windows page.

content/en/docs/tasks/debug-application-cluster/window.md Outdated Show resolved Hide resolved
@marosset marosset force-pushed the move-windows-troubleshooting-1.24 branch from 685d2c8 to bb9b9dc Compare March 31, 2022 18:17
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shannonxtreme
To complete the pull request process, please assign tengqm after the PR has been reviewed.
You can assign the PR to them by writing /assign @tengqm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset marosset force-pushed the move-windows-troubleshooting-1.24 branch from bb9b9dc to 168fdb7 Compare March 31, 2022 18:32
@marosset marosset force-pushed the move-windows-troubleshooting-1.24 branch from 168fdb7 to 534c45f Compare March 31, 2022 18:39
@marosset
Copy link
Contributor Author

marosset commented Mar 31, 2022 •
edited
Loading

/hold
for other updates outlined in #31428 can all merge together.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2022
@marosset marosset changed the title WIP: Move windows troubleshooting 1.24 Move windows troubleshooting 1.24 Mar 31, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2022
@marosset
Copy link
Contributor Author

marosset commented Apr 5, 2022

/hold
We want all the PRs that break up /modify https://kubernetes.io/docs/setup/production-environment/windows/intro-windows-in-kubernetes/
See #31851 (comment)

@nate-double-u
Copy link
Contributor

Hi @marosset, I don't think this PR should target dev-1.24

@marosset
Copy link
Contributor Author

/close
I will squash the commits and create a single PR with all of the related changes targeting main.

@k8s-ci-robot
Copy link
Contributor

@marosset: Closed this PR.

In response to this:

/close
I will squash the commits and create a single PR with all of the related changes targeting main.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nate-double-u
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the 1.24 milestone Apr 27, 2022
@marosset marosset mentioned this pull request May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@shannonxtreme shannonxtreme shannonxtreme approved these changes

@perithompson perithompson Awaiting requested review from perithompson

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language refactor Indicates a PR with large refactoring changes e.g. removes files or moves content sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marosset @tengqm @k8s-ci-robot @nate-double-u @shannonxtreme