-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving Windows security info to new page #31851
Moving Windows security info to new page #31851
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: 9b68767 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/621815a2b1cba7000808f549 |
/sig security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some suggestions - what do you think @marosset ?
Privileged containers are [not supported](#compatibility-v1-pod-spec-containers-securitycontext) on Windows. | ||
Instead [HostProcess containers](/docs/tasks/configure-pod-container/create-hostprocess-pod) can be used on Windows to perform many of the tasks performed by privileged containers on Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this belongs elsewhere, perhaps as a note in https://kubernetes.io/docs/concepts/workloads/pods/#privileged-mode-for-containers ?
Maybe at least restate it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this is already stated at https://kubernetes.io/docs/concepts/workloads/pods/#privileged-mode-for-containers
If your cluster has the WindowsHostProcessContainers feature enabled, you can create a Windows HostProcess pod by setting the windowsOptions.hostProcess flag on the security context of the pod spec. All containers in these pods must run as Windows HostProcess containers. HostProcess pods run directly on the host and can also be used to perform administrative tasks as is done with Linux privileged containers.
Should we just remove mention of it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little bit tidier to use the same or very similar wording in both places; it's also fine to leave them different and then after this merges log a good-first-issue about making the two places match.
(We like to have a nice pool of easily tractable fixes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would qualify as an easily tractable fix so I can open that issue and add the help-wanted tag after this merges if that could help new contributors get started making PRs into this repo.
/assign @brasmith-ms |
@marosset: GitHub didn't allow me to assign the following users: brasmith-ms. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a content and style perspective. There are some nits to if you'd like to.
Once you're happy, please squash commits.
Signed-off-by: Mark Rossetti <[email protected]>
bafd73a
to
9b68767
Compare
@sftim I incorporated your feedback and rebased. |
- jayunit100 | ||
- jsturtevant | ||
- marosset | ||
- perithompson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: s/perithompson/aravindh
Let's get the balls rolling. Approving based the feedback/revision history. |
LGTM label has been added. Git tree hash: 62019ad90a1229c7effce34f430ff3dab242e184
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tengqm Thanks for merging this. I'm OK either way. |
At this point a revert won't achieve what we'd want (reduced workload for the release docs team). I guess these are OK to live with, and the changes are beneficial. |
From SIG Docs side, we could have added a hold and didn't. Sorry about that. |
What I had in mind when kicking this in was: 1. a refactoring work is nontrivial, we will need to achieve the goal in a step by step way; 2. the Windows docs are well maintained so far and people are actively improving them, we are supposed to encourage that; 3. having a PR not moving on for 20+ days (as you both mentioned, no WIP sign) worries me, from the review history of this one, I can only see some non-blocking nits. I'm sorry for not checking the meeting notes for these. |
SIG Docs discussed, in a meeting yesterday, that once there are a bunch of PRs that are ready to merge into the main branch, SIG Docs can help get those merged. In my view, there great part of the effort is lining up PRs that are good to merge, and actually merging them is more restricted (needs an approver's time) but less effort. We also agreed in that meeting that those involved favor continuing to work towards doing that merge after the v1.24 release. |
Moving Windows security information to a new page
Part of #31428
/label refactor
/sig windows