Move Windows storage concepts to a new page #31900

aravindhp · 2022-02-25T01:15:36Z

Moving Windows storage concepts to a new page.

Part of #31428

/label refactor
/sig windows

aravindhp · 2022-02-25T01:16:23Z

/cc @marosset @jsturtevant @brasmith-ms @immuzz

k8s-ci-robot · 2022-02-25T01:16:26Z

@aravindhp: GitHub didn't allow me to request PR reviews from the following users: brasmith-ms.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @marosset @jsturtevant @brasmith-ms @immuzz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2022-02-25T01:29:27Z

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: f2b16ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62210402f6bb9a0007df4742

😎 Browse the preview: https://deploy-preview-31900--kubernetes-io-main-staging.netlify.app

aravindhp · 2022-03-02T15:29:16Z

/retitle Move Windows storage concepts to a new page

marosset · 2022-03-03T17:32:57Z

/assign

marosset · 2022-03-03T17:33:41Z

@aravindhp can you update the PR to target the dev-1.24 branch to match the rest of the PRs associated with #31428?

content/en/docs/concepts/storage/windows-storage.md

marosset · 2022-03-03T17:53:43Z

Mostly LGTM,
thanks!

marosset · 2022-03-03T18:09:10Z

/sig storage

aravindhp · 2022-03-03T18:26:22Z

@marosset I have made the changes you requested

marosset · 2022-03-03T18:36:20Z

/lgtm

k8s-ci-robot · 2022-03-03T18:36:39Z

LGTM label has been added.

Git tree hash: df3d4bd229f4eaf1de968e63aa5d4e0d7622a6a2

jsturtevant · 2022-03-04T15:56:55Z

/lgtm

kbhawkey · 2022-03-05T01:23:14Z

Page previews:
https://deploy-preview-31900--kubernetes-io-main-staging.netlify.app/docs/concepts/storage/windows-storage/
https://deploy-preview-31900--kubernetes-io-main-staging.netlify.app/docs/concepts/storage/volumes/#windows-csi-proxy

kbhawkey · 2022-03-05T01:23:57Z

Ping
/sig storage

kbhawkey · 2022-03-05T01:24:42Z

content/en/docs/concepts/storage/volumes.md

+
+CSI node plugins (especially those associated with persistent volumes exposed as
+either block devices or over a shared file-system) need to perform various privileged
+operations like scanning of disk devices, mounting of file systems, etc. These


nit: Try to avoid using etc.

kbhawkey · 2022-03-05T01:25:11Z

Changes LGTM

msau42 · 2022-03-09T06:34:20Z

content/en/docs/concepts/storage/volumes.md

@@ -1271,6 +1271,21 @@ for more information.
 For more information on how to develop a CSI driver, refer to the
 [kubernetes-csi documentation](https://kubernetes-csi.github.io/docs/)

+#### Windows CSI proxy
+
+{{< feature-state for_k8s_version="v1.19" state="beta" >}}


This is GA as of 1.22

msau42 · 2022-03-09T06:36:06Z

content/en/docs/concepts/storage/windows-storage.md

+[plugin](/docs/concepts/storage/volumes/#types-of-volumes).
+The following broad classes of Kubernetes volume plugins are supported on Windows:
+
+* [`FlexVolume plugins`](/docs/concepts/storage/volumes/#flexVolume)


FlexVolume is deprecated. We may want to add a notice here.

msau42 · 2022-03-09T06:37:11Z

content/en/docs/concepts/storage/windows-storage.md

@@ -0,0 +1,59 @@
+---
+reviewers:
+- jayunit100


Please add @jingxu97 and @mauriciopoppe as reviewers

aravindhp · 2022-03-22T17:36:54Z

@msau42 I have addressed your comments. PTAL.

k8s-ci-robot · 2022-03-22T17:51:35Z

New changes are detected. LGTM label has been removed.

netlify · 2022-03-22T17:51:41Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`8a805cb`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62686601648f630008807b3e

k8s-ci-robot · 2022-03-22T17:53:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign celestehorgan after the PR has been reviewed.
You can assign the PR to them by writing /assign @celestehorgan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

marosset · 2022-04-05T18:43:09Z

/hold
We want all the PRs that break up /modify https://kubernetes.io/docs/setup/production-environment/windows/intro-windows-in-kubernetes/
See #31851 (comment)

nate-double-u · 2022-04-26T20:01:44Z

Hi @aravindhp, I'm not sure if this PR should target dev-1.24

/cc @marosset

- Move FlexVolume plugins section to docs/concepts/storage/volumes.md - Move CSI plugins section to en/docs/concepts/storage/volumes.md - Move in-tree plugins section to en/docs/concepts/storage/volumes.md

aravindhp · 2022-04-28T16:35:16Z

/close
/cc @marosset

k8s-ci-robot · 2022-04-28T16:35:32Z

@aravindhp: Closed this PR.

In response to this:

/close
/cc @marosset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot requested review from immuzz and marosset February 25, 2022 01:16

k8s-ci-robot requested a review from jsturtevant February 25, 2022 01:16

k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 25, 2022

k8s-ci-robot requested review from jayunit100 and msau42 February 25, 2022 01:16

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 25, 2022

jihoon-seo mentioned this pull request Feb 25, 2022

Outdated Korean windows/intro-windows-in-kubernetes.md #30364

Closed

k8s-ci-robot changed the title ~~WIP: Move Windows storage concepts to a new page~~ Move Windows storage concepts to a new page Mar 2, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2022

marosset mentioned this pull request Mar 3, 2022

Overhaul Windows documentation #31428

Open

31 tasks

k8s-ci-robot assigned marosset Mar 3, 2022

marosset reviewed Mar 3, 2022

View reviewed changes

content/en/docs/concepts/storage/windows-storage.md Outdated Show resolved Hide resolved

aravindhp force-pushed the move-windows-storage branch from c66b242 to f2b16ca Compare March 3, 2022 18:08

aravindhp changed the base branch from main to dev-1.24 March 3, 2022 18:08

k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Mar 3, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022

k8s-ci-robot assigned jsturtevant Mar 4, 2022

kbhawkey reviewed Mar 5, 2022

View reviewed changes

msau42 reviewed Mar 9, 2022

View reviewed changes

aravindhp force-pushed the move-windows-storage branch from f2b16ca to b3e914a Compare March 22, 2022 17:34

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2022

k8s-ci-robot requested a review from marosset March 22, 2022 17:51

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2022

aravindhp force-pushed the move-windows-storage branch from b3e914a to 806c71f Compare April 26, 2022 21:08

Move Windows storage concepts to a new page

8a805cb

- Move FlexVolume plugins section to docs/concepts/storage/volumes.md - Move CSI plugins section to en/docs/concepts/storage/volumes.md - Move in-tree plugins section to en/docs/concepts/storage/volumes.md

aravindhp force-pushed the move-windows-storage branch from 806c71f to 8a805cb Compare April 26, 2022 21:37

k8s-ci-robot closed this Apr 28, 2022

marosset mentioned this pull request May 9, 2022

Windows documentation overhaul #33582

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Windows storage concepts to a new page #31900

Move Windows storage concepts to a new page #31900

aravindhp commented Feb 25, 2022

aravindhp commented Feb 25, 2022

k8s-ci-robot commented Feb 25, 2022

netlify bot commented Feb 25, 2022 •

edited

Loading

aravindhp commented Mar 2, 2022

marosset commented Mar 3, 2022

marosset commented Mar 3, 2022

marosset commented Mar 3, 2022

marosset commented Mar 3, 2022

aravindhp commented Mar 3, 2022

marosset commented Mar 3, 2022

k8s-ci-robot commented Mar 3, 2022

jsturtevant commented Mar 4, 2022

kbhawkey commented Mar 5, 2022

kbhawkey commented Mar 5, 2022

kbhawkey Mar 5, 2022

kbhawkey commented Mar 5, 2022

msau42 Mar 9, 2022

msau42 Mar 9, 2022

msau42 Mar 9, 2022

aravindhp commented Mar 22, 2022

k8s-ci-robot commented Mar 22, 2022

netlify bot commented Mar 22, 2022 •

edited

Loading

k8s-ci-robot commented Mar 22, 2022

marosset commented Apr 5, 2022

nate-double-u commented Apr 26, 2022 •

edited

Loading

aravindhp commented Apr 28, 2022

k8s-ci-robot commented Apr 28, 2022

Move Windows storage concepts to a new page #31900

Move Windows storage concepts to a new page #31900

Conversation

aravindhp commented Feb 25, 2022

aravindhp commented Feb 25, 2022

k8s-ci-robot commented Feb 25, 2022

netlify bot commented Feb 25, 2022 • edited Loading

aravindhp commented Mar 2, 2022

marosset commented Mar 3, 2022

marosset commented Mar 3, 2022

marosset commented Mar 3, 2022

marosset commented Mar 3, 2022

aravindhp commented Mar 3, 2022

marosset commented Mar 3, 2022

k8s-ci-robot commented Mar 3, 2022

jsturtevant commented Mar 4, 2022

kbhawkey commented Mar 5, 2022

kbhawkey commented Mar 5, 2022

kbhawkey Mar 5, 2022

Choose a reason for hiding this comment

kbhawkey commented Mar 5, 2022

msau42 Mar 9, 2022

Choose a reason for hiding this comment

msau42 Mar 9, 2022

Choose a reason for hiding this comment

msau42 Mar 9, 2022

Choose a reason for hiding this comment

aravindhp commented Mar 22, 2022

k8s-ci-robot commented Mar 22, 2022

netlify bot commented Mar 22, 2022 • edited Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

k8s-ci-robot commented Mar 22, 2022

marosset commented Apr 5, 2022

nate-double-u commented Apr 26, 2022 • edited Loading

aravindhp commented Apr 28, 2022

k8s-ci-robot commented Apr 28, 2022

netlify bot commented Feb 25, 2022 •

edited

Loading

netlify bot commented Mar 22, 2022 •

edited

Loading

nate-double-u commented Apr 26, 2022 •

edited

Loading