Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Replace k8s.gcr.io with registry.k8s.io #39247

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 3, 2023

Split from #39236

Japanese changes only. I haven't verified that these are level with upstream (English); however, these changes are equivalent and appropriate to make.

The example manifests are level with English.

sftim added 2 commits February 3, 2023 15:59
Related to registry change, but also adopting any other changes from
English upstream.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot requested a review from bells17 February 3, 2023 16:00
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot requested a review from t-inu February 3, 2023 16:00
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2023
@netlify
Copy link

netlify bot commented Feb 3, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f4ac392
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63dd2f82f0264e00092dff5d
😎 Deploy Preview https://deploy-preview-39247--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reylejano
Copy link
Member

Hi @kubernetes/sig-docs-ja-owners , please take a look

@nasa9084
Copy link
Member

nasa9084 commented Feb 6, 2023

/assign
/approve
Thank you~

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2023
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f88b3c8f1b854598d917707447313c2fd6da794

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084, t-inu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c7a0cb0 into kubernetes:main Feb 6, 2023
@sftim sftim deleted the 20230303_new_reg_ja branch September 23, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants