[ja] Set heading IDs in daemonset.md and assign-pods-nodes.md #39484
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thank you for your PR! LGTM! |
|
|
||
| ### デフォルトスケジューラーによってスケジューリングされる場合 | ||
| ### デフォルトスケジューラーによってスケジューリングされる場合 {#scheduled-by-default-scheduler} |
There was a problem hiding this comment.
This header line was already removed in en.
"scheduled-by-default-scheduler" was correct in older page, I think that it is OK.
I think that this line will be removed in the near future.
There was a problem hiding this comment.
Agree with the comment of @s-kawamura-w664 .
| @@ -7,13 +7,13 @@ weight: 120 | |||
| <!-- overview --> | |||
| このページでは、KubernetesのPodをKubernetesクラスター上の特定のノードに割り当てる方法を説明します。 | |||
|
|
|||
| ## {{% heading "prerequisites" %}} | |||
| ## {{% heading "prerequisites" %}} {#before-you-begin} | |||
There was a problem hiding this comment.
Currently, the anchor of heading shortcode will be specified like this. I think It is currect.
In the future, I think it would be good to generate the anchor in the headering shortcode.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 065bac50f48c9c957fe1caeb5e1bfd37924f5ea5
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nasa9084 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Related PR: #38800
We would like to use English heading IDs to link the following pages.
https://kubernetes.io/ja/docs/concepts/workloads/controllers/daemonset/
https://kubernetes.io/ja/docs/tasks/configure-pod-container/assign-pods-nodes/
In this PR, I set English IDs for all Japanese headings in the target pages.
The purpose of this PR only sets IDs, not updating the contents and the heading names.
en:
https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/
https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes/