Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Update content/ja/docs/tasks/configure-pod-container/security-context.md #47497

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[ja] Update content/ja/docs/tasks/configure-pod-container/security-context.md #47497

merged 1 commit into from
Aug 16, 2024

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented Aug 14, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2024
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Aug 14, 2024
@k8s-ci-robot k8s-ci-robot requested a review from t-inu August 14, 2024 11:28
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 14, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0e3bb4b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66bd7e24b80bfd0008a7ea33
😎 Deploy Preview https://deploy-preview-47497--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@everpeace everpeace mentioned this pull request Aug 14, 2024
Merged
@everpeace everpeace marked this pull request as draft August 14, 2024 12:46
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2024
@everpeace everpeace force-pushed the update-ja-security-context branch 2 times, most recently from d9fd0b1 to 86117bc Compare August 14, 2024 13:04
@everpeace everpeace marked this pull request as ready for review August 14, 2024 13:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kakts August 14, 2024 13:28
Okabe-Junya
Okabe-Junya reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コントリビューションありがとうございます！取り急ぎコメントさせていただいたのでご確認お願いします！

content/ja/docs/tasks/configure-pod-container/security-context.md Outdated Show resolved Hide resolved
content/ja/docs/tasks/configure-pod-container/security-context.md Show resolved Hide resolved
content/ja/docs/tasks/configure-pod-container/security-context.md Show resolved Hide resolved
content/ja/docs/tasks/configure-pod-container/security-context.md Show resolved Hide resolved
content/ja/docs/tasks/configure-pod-container/security-context.md Show resolved Hide resolved
@everpeace everpeace force-pushed the update-ja-security-context branch from c3a4623 to e981fa7 Compare August 15, 2024 01:08
everpeace
everpeace commented Aug 15, 2024
View reviewed changes
Copy link
Contributor Author

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

早速のレビューありがとうございました。頂いたコメント対応出来たと思いますので、再度レビューをお願いいたします。

content/ja/docs/tasks/configure-pod-container/security-context.md Show resolved Hide resolved
content/ja/docs/tasks/configure-pod-container/security-context.md Outdated Show resolved Hide resolved
Okabe-Junya
Okabe-Junya reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます、LGTMです！

/lgtm
/assign inductor
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 24c90dafcd6eb644c1eaaf93327f28136251cffc

b1gb4by
b1gb4by reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@b1gb4by b1gb4by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい部分にはなりますが、レビューさせていただきました！

content/ja/docs/tasks/configure-pod-container/security-context.md Show resolved Hide resolved
content/ja/docs/tasks/configure-pod-container/security-context.md Show resolved Hide resolved
content/ja/docs/tasks/configure-pod-container/security-context.md Show resolved Hide resolved
content/ja/docs/tasks/configure-pod-container/security-context.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2024
@everpeace @Okabe-Junya @b1gb4by
[ja] updated content/ja/docs/tasks/configure-pod-container/security-c…
0e3bb4b 
…ontext.md

- updated "Efficient SELinux volume relabeling" section
- added "Managing access to the `/proc` filesystem" section
- added "fine-grained SupplementalGroups control" section
- added "Set the AppArmor Profile for a Container" section
- s|ユーザ|ユーザー|g
- s|ユーザー/グループ|ユーザー、グループ|
- removed unnecessary space
- applied suggestions from code review

Co-authored-by: Junya Okabe <[email protected]>
Co-authored-by: Taisuke Okamoto <[email protected]>
@everpeace everpeace force-pushed the update-ja-security-context branch from 7fa3097 to 0e3bb4b Compare August 15, 2024 04:03
everpeace
everpeace commented Aug 15, 2024
View reviewed changes
Copy link
Contributor Author

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b1gb4by Suggestionまでありがとうございました！すべて適用させていただきました 🙇
@Okabe-Junya squashして1commitにまとめました。

再度レビューお願いいたします 🙇

Okabe-Junya
Okabe-Junya reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 358840cce7bcbc2f74ac533a32921cd3eda4eab0

@b1gb4by
Copy link
Contributor

b1gb4by commented Aug 15, 2024

/lgtm

inductor
inductor approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@inductor inductor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 709795e into kubernetes:main Aug 16, 2024
6 checks passed
@everpeace everpeace deleted the update-ja-security-context branch August 16, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1gb4by b1gb4by b1gb4by left review comments

@Okabe-Junya Okabe-Junya Okabe-Junya left review comments

@inductor inductor inductor approved these changes

@t-inu t-inu Awaiting requested review from t-inu

@kakts kakts Awaiting requested review from kakts

Assignees

@inductor inductor

@b1gb4by b1gb4by

@Okabe-Junya Okabe-Junya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@everpeace @k8s-ci-robot @b1gb4by @inductor @Okabe-Junya