Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Release v0.83.0 #1483

Merged
merged 1 commit into from
Dec 14, 2022
Merged

[main] Release v0.83.0 #1483

merged 1 commit into from
Dec 14, 2022

Conversation

kubevirt-bot
Copy link
Collaborator

What this PR does / why we need it:
Release v0.83.0

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Dec 14, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2022
@kubevirt-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@oshoval
Copy link
Collaborator

oshoval commented Dec 14, 2022

test/releases/99.0.0.go:8:7: secondaryDNSDeployment redeclared in this block
	/tmp/cnao/cluster-network-addons-operator/test/releases/0.83.0.go:8:32: previous declaration
FAIL	github.com/kubevirt/cluster-network-addons-operator/test/e2e/lifecycle [build failed]
FAIL

Hmm
Basically we can remove that const, but then SonarCloud suggest to add it
so if we ignore its suggestion we will be fine, if its ok to do

maybe we can compile / link just the right release file ? (it might fails already on compilation though)

@oshoval
Copy link
Collaborator

oshoval commented Dec 14, 2022

secondaryDNSDeployment

#1484

@oshoval
Copy link
Collaborator

oshoval commented Dec 14, 2022

Can you please rebase / recreate ?
const fix was merged

EDIT - retesting as prow rebases upon test

@oshoval
Copy link
Collaborator

oshoval commented Dec 14, 2022

/retest

@kubevirt-bot kubevirt-bot merged commit de744a3 into main Dec 14, 2022
"github.com/kubevirt/cluster-network-addons-operator/pkg/components"
)

const secondaryDNSDeployment = "secondary-dns"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that here we will still have this const
on future versions we won't
It isn't that important basically imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants