Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump, cnao: k8s-1.2[4,5] to cnao v0.82.0 -- take2 #933

Merged
merged 1 commit into from
Dec 15, 2022
Merged

bump, cnao: k8s-1.2[4,5] to cnao v0.82.0 -- take2 #933

merged 1 commit into from
Dec 15, 2022

Conversation

ormergi
Copy link
Contributor

@ormergi ormergi commented Dec 13, 2022 •
edited
Loading

This PR bump CNAO to v0.82.0.
Following #932 it's now possible to bump CNAO to v0.82.0 which brings Multus v4.

CNAO v0.82.0 introduces:

  • Multus v4 which now enables hotplug/unplug networks to pods at run time.
  • The dynamic networks controller into the kubevirt eco-system
    And thus enabling kubevirt to hotplug network interfaces into pods.

This is how this PR was verified on local env:

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 13, 2022
@ormergi
Copy link
Contributor Author

ormergi commented Dec 13, 2022

/test check-provision-k8s-1.25

1 similar comment
@ormergi
Copy link
Contributor Author

ormergi commented Dec 13, 2022

/test check-provision-k8s-1.25

@ormergi
Copy link
Contributor Author

ormergi commented Dec 13, 2022

/cc @maiqueb @phoracek @brianmcarey @dhiller

@ormergi ormergi marked this pull request as ready for review December 15, 2022 07:37
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2022
@kubevirt-bot kubevirt-bot requested a review from oshoval December 15, 2022 07:38
@maiqueb @ormergi
bump, cnao: k8s-1.2[4,5] to cnao v0.82.0 (kubevirt#910)
be5102d 
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Or Mergi <[email protected]>
@ormergi ormergi force-pushed the bump-cnao-to-v0.82.0-take2 branch from 8bcbc53 to be5102d Compare December 15, 2022 07:38
@ormergi
Copy link
Contributor Author

ormergi commented Dec 15, 2022

Rebased

@ormergi
Copy link
Contributor Author

ormergi commented Dec 15, 2022

/uncc @stu-gott @jean-edouard

@oshoval
Copy link
Contributor

oshoval commented Dec 15, 2022 •
edited
Loading

Can you please bump directly to 0.83.0 ?
kubevirt/cluster-network-addons-operator#1483
It includes KubeSecondaryDNS
Note that it will be deployed on the sig-network lanes of kubevirt
but it shouldn't harm

If you prefer that it will be done in steps its ok

maiqueb
maiqueb approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@ormergi
Copy link
Contributor Author

ormergi commented Dec 15, 2022

Can you please bump directly to 0.83.0 ? kubevirt/cluster-network-addons-operator#1483 It includes KubeSecondaryDNS Note that it will be deployed on the sig-network lanes of kubevirt but it shouldn't harm

If you prefer that it will be done in steps its ok

Usually, I would have no problem with that, but since we had issues with the last bump that took a lot of time to fix I prefer to do it in steps this time 🙂

@kubevirt-bot
Copy link
Contributor

@ormergi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.23-vgpu be5102d link false /test check-up-kind-1.23-vgpu
check-provision-k8s-1.26 be5102d link false /test check-provision-k8s-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@phoracek
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@kubevirt-bot kubevirt-bot merged commit 6304ac8 into kubevirt:main Dec 15, 2022
@ormergi ormergi mentioned this pull request Dec 15, 2022
Merged
@brianmcarey brianmcarey mentioned this pull request Dec 16, 2022
Merged
ormergi added a commit to ormergi/kubevirtci that referenced this pull request Mar 1, 2023
@ormergi
Revert "bump, cnao: k8s-1.2[4,5] to cnao v0.82.0 (kubevirt#910) (kube…
b3581bd 
…virt#933)"

This reverts commit 6304ac8.

CNAO v0.82.0 deploys Multus V4-alpha which is not GA'ed yet.
Revert CNAO to v0.80.0 which deploys Multus V3 (GA) in order for
sig-network lanes to tests against it.

Signed-off-by: Or Mergi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiqueb maiqueb maiqueb approved these changes

@brianmcarey brianmcarey Awaiting requested review from brianmcarey

@dhiller dhiller Awaiting requested review from dhiller

@phoracek phoracek Awaiting requested review from phoracek

@oshoval oshoval Awaiting requested review from oshoval

Assignees

@maiqueb maiqueb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ormergi @kubevirt-bot @oshoval @phoracek @maiqueb