Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use the new SSP operator [release-1.3] #1026

Merged
merged 19 commits into from
Jan 7, 2021

Conversation

zcahana
Copy link
Contributor

@zcahana zcahana commented Dec 28, 2020

This PR mirrors #966 but is targeted at the release-1.3 branch.

Switch to use the new SSP operator.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL labels Dec 28, 2020
@zcahana zcahana changed the title New ssp 1.3 Switch to use the new SSP operator [release-1.3] Dec 28, 2020
Signed-off-by: HCO Bump Bot <[email protected]>
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 28, 2020
@hco-bot
Copy link
Collaborator

hco-bot commented Dec 28, 2020

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Dec 28, 2020

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Dec 29, 2020

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Collaborator

@zcahana: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-upgrade-prev-aws 801689f2643dc6371962563c72a9b49fc1c580f7 link /test hco-e2e-upgrade-prev-aws
ci/prow/hco-e2e-upgrade-aws 801689f2643dc6371962563c72a9b49fc1c580f7 link /test hco-e2e-upgrade-aws
ci/prow/hco-e2e-image-index-azure 801689f2643dc6371962563c72a9b49fc1c580f7 link /test hco-e2e-image-index-azure
ci/prow/hco-e2e-upgrade-prev-azure 801689f2643dc6371962563c72a9b49fc1c580f7 link /test hco-e2e-upgrade-prev-azure
ci/prow/hco-e2e-upgrade-azure 801689f2643dc6371962563c72a9b49fc1c580f7 link /test hco-e2e-upgrade-azure
ci/prow/hco-e2e-image-index-gcp 801689f2643dc6371962563c72a9b49fc1c580f7 link /test hco-e2e-image-index-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Dec 29, 2020

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@zcahana
Copy link
Contributor Author

zcahana commented Jan 6, 2021

/test hco-e2e-upgrade-prev-aws

@kubevirt-bot
Copy link
Contributor

@zcahana: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zcahana
Copy link
Contributor Author

zcahana commented Jan 6, 2021

/test hco-e2e-upgrade-prev-aws

@kubevirt-bot
Copy link
Contributor

@zcahana: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Jan 7, 2021

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Due to other errors, the reconciliation
loop can fail and HCO conditions can temporary
assume Unknown status which is sematically acceptable.
Let's tolerate it.

Test code only.

Signed-off-by: Simone Tiraboschi <[email protected]>
@zcahana
Copy link
Contributor Author

zcahana commented Jan 7, 2021

Cherry-picked from #1039 to speed-up testing.

@zcahana
Copy link
Contributor Author

zcahana commented Jan 7, 2021

/override-bot

@tiraboschi
Copy link
Member

It successfully passed hco-e2e-upgrade-prev-aws and hco-e2e-image-index-aws which are the two most relevant lanes (hco-e2e-upgrade-* are not that relevant because removing the old SSP operator without really bumping the .y version is not an interesting use case) for this PR,
everything else is probably just environmental so we can safely tolerate
/override hco-e2e-upgrade-aws
/override hco-e2e-upgrade-prev-azure

@kubevirt-bot
Copy link
Contributor

@tiraboschi: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • hco-e2e-upgrade-aws
  • hco-e2e-upgrade-prev-azure

Only the following contexts were expected:

  • ci/prow/ci-index
  • ci/prow/hco-e2e-image-index-aws
  • ci/prow/hco-e2e-image-index-azure
  • ci/prow/hco-e2e-image-index-gcp
  • ci/prow/hco-e2e-upgrade-aws
  • ci/prow/hco-e2e-upgrade-azure
  • ci/prow/hco-e2e-upgrade-prev-aws
  • ci/prow/hco-e2e-upgrade-prev-azure
  • ci/prow/images
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.17
  • tide

In response to this:

It successfully passed hco-e2e-upgrade-prev-aws and hco-e2e-image-index-aws which are the two most relevant lanes (hco-e2e-upgrade-* are not that relevant because removing the old SSP operator without really bumping the .y version is not an interesting use case) for this PR,
everything else is probably just environmental so we can safely tolerate
/override hco-e2e-upgrade-aws
/override hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Jan 7, 2021

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zcahana
Copy link
Contributor Author

zcahana commented Jan 7, 2021

Per discussion with @tiraboschi and @nunnatsa, we'll override the hco-e2e-upgrade-aws and hco-e2e-upgrade-azure tests which are bound to fail in this PR, since they try to upgrade from a 1.3.0 CSV version (i.e., without old SSP CRDs) while running an HCO image that tries to create these CRDs, causing a "no such CRD" test failures.

/override hco-e2e-upgrade-aws
/override hco-e2e-upgrade-azure

@kubevirt-bot
Copy link
Contributor

@zcahana: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • hco-e2e-upgrade-aws
  • hco-e2e-upgrade-azure

Only the following contexts were expected:

  • ci/prow/ci-index
  • ci/prow/hco-e2e-image-index-aws
  • ci/prow/hco-e2e-image-index-azure
  • ci/prow/hco-e2e-image-index-gcp
  • ci/prow/hco-e2e-upgrade-aws
  • ci/prow/hco-e2e-upgrade-azure
  • ci/prow/hco-e2e-upgrade-prev-aws
  • ci/prow/hco-e2e-upgrade-prev-azure
  • ci/prow/images
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.17
  • tide

In response to this:

Per discussion with @tiraboschi and @nunnatsa, we'll override the hco-e2e-upgrade-aws and hco-e2e-upgrade-azure tests which are bound to fail in this PR, since they try to upgrade from a 1.3.0 CSV version (i.e., without old SSP CRDs) while running an HCO image that tries to create these CRDs, causing a "no such CRD" test failures.

/override hco-e2e-upgrade-aws
/override hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zcahana
Copy link
Contributor Author

zcahana commented Jan 7, 2021

Retrying overrides:
/override ci/prow/hco-e2e-upgrade-aws
/override ci/prow/hco-e2e-upgrade-azure

@kubevirt-bot
Copy link
Contributor

@zcahana: Overrode contexts on behalf of zcahana: ci/prow/hco-e2e-upgrade-aws, ci/prow/hco-e2e-upgrade-azure

In response to this:

Retrying overrides:
/override ci/prow/hco-e2e-upgrade-aws
/override ci/prow/hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jan 7, 2021

@zcahana: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-image-index-gcp 1566f99 link /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-upgrade-prev-azure eef8d0c link /test hco-e2e-upgrade-prev-azure
ci/prow/hco-e2e-upgrade-aws eef8d0c link /test hco-e2e-upgrade-aws
ci/prow/hco-e2e-upgrade-azure eef8d0c link /test hco-e2e-upgrade-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021
@kubevirt-bot
Copy link
Contributor

@nunnatsa: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • hco-e2e-upgrade-azure

Only the following contexts were expected:

  • ci/prow/ci-index
  • ci/prow/hco-e2e-image-index-aws
  • ci/prow/hco-e2e-image-index-azure
  • ci/prow/hco-e2e-image-index-gcp
  • ci/prow/hco-e2e-upgrade-aws
  • ci/prow/hco-e2e-upgrade-azure
  • ci/prow/hco-e2e-upgrade-prev-aws
  • ci/prow/hco-e2e-upgrade-prev-azure
  • ci/prow/images
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.17
  • tide

In response to this:

/override hco-e2e-upgrade-azure

as it can't pass until the image is updated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Jan 7, 2021

/override ci/prow/hco-e2e-upgrade-azure

as it can't pass until the image is updated

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-azure

In response to this:

/override ci/prow/hco-e2e-upgrade-azure

as it can't pass until the image is updated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 5c2f99b into kubevirt:release-1.3 Jan 7, 2021
@zcahana zcahana deleted the new_ssp_1.3 branch January 7, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants