Fix issues with high availability detection #3205

nunnatsa · 2024-12-12T14:07:53Z

What this PR does / why we need it:

make the status field a pointer to bool, to distinglish between false and field not set.
On mutation webhook, fix the eviction strategy if SNO becam HA.
fix an issue where the status field is not set if no node is added or deleted.
fix unit test (assert old HCO instead of HCO from client)
fix issue in the node controller, to ignore error if HCO is not present.

Jira Ticket:

none

Release note:

None

coveralls · 2024-12-12T14:35:04Z

Pull Request Test Coverage Report for Build 12338107598

Details

27 of 34 (79.41%) changed or added relevant lines in 4 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.06%) to 71.68%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/components/components.go	0	1	0.0%
controllers/nodes/nodes_controller.go	8	14	57.14%

Files with Coverage Reduction	New Missed Lines	%
controllers/commontestutils/testUtils.go	3	52.84%

Totals
Change from base Build 12337030246:	0.06%
Covered Lines:	6120
Relevant Lines:	8538

💛 - Coveralls

hco-bot · 2024-12-12T18:54:17Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2024-12-12T18:54:21Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hco-bot · 2024-12-15T08:53:54Z

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

kubevirt-bot · 2024-12-15T08:53:58Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hco-bot · 2024-12-15T09:10:50Z

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

kubevirt-bot · 2024-12-15T09:10:54Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

In response to this:

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hco-bot · 2024-12-15T09:44:59Z

hco-e2e-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-aws

kubevirt-bot · 2024-12-15T09:45:03Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-aws

In response to this:

hco-e2e-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

* add the missing "watch" permission for nodes. * make the status field a pointer to bool, to distinglish between false and field not set. * On mutation webhook, fix the eviction strategy if SNO becam HA. * fix an issue where the status field is not set if no node is added or deleted. * fix unit test (assert old HCO instead of HCO from client) * fix issue in the node controller, to ignore error if HCO is not present. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>

sonarqubecloud · 2024-12-15T10:43:14Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

hco-bot · 2024-12-15T12:54:13Z

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

kubevirt-bot · 2024-12-15T12:54:19Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

In response to this:

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hco-bot · 2024-12-15T13:18:16Z

hco-e2e-operator-sdk-gcp, hco-e2e-operator-sdk-aws lanes succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure
hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws
hco-e2e-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-aws

kubevirt-bot · 2024-12-15T13:18:25Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

In response to this:

hco-e2e-operator-sdk-gcp, hco-e2e-operator-sdk-aws lanes succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure
hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws
hco-e2e-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nunnatsa · 2024-12-16T06:22:13Z

/retest

nunnatsa · 2024-12-16T07:17:26Z

/cherry-pick release-1.13

kubevirt-bot · 2024-12-16T07:17:29Z

@nunnatsa: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2024-12-16T08:32:46Z

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure	`0505810`	link	true	`/test hco-e2e-consecutive-operator-sdk-upgrades-azure`
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws	`0505810`	link	false	`/test hco-e2e-upgrade-prev-operator-sdk-sno-aws`
ci/prow/hco-e2e-operator-sdk-azure	`0505810`	link	true	`/test hco-e2e-operator-sdk-azure`
ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure	`0505810`	link	false	`/test hco-e2e-upgrade-operator-sdk-sno-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

hco-bot · 2024-12-16T08:41:16Z

hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

kubevirt-bot · 2024-12-16T08:41:22Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

In response to this:

hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

orenc1

/approve
/thanks

kubevirt-bot · 2024-12-16T08:43:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [orenc1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot · 2024-12-16T09:14:37Z

@nunnatsa: #3205 failed to apply on top of branch "release-1.13":

Applying: Fix issues with high availability detection
Using index info to reconstruct a base tree...
M	api/v1beta1/hyperconverged_types.go
M	controllers/hyperconverged/hyperconverged_controller.go
M	deploy/cluster_role.yaml
A	deploy/index-image/community-kubevirt-hyperconverged/1.14.0/manifests/kubevirt-hyperconverged-operator.v1.14.0.clusterserviceversion.yaml
A	deploy/olm-catalog/community-kubevirt-hyperconverged/1.14.0/manifests/kubevirt-hyperconverged-operator.v1.14.0.clusterserviceversion.yaml
M	docs/api.md
M	pkg/components/components.go
M	tests/func-tests/node_placement_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/func-tests/node_placement_test.go
Auto-merging pkg/components/components.go
Auto-merging docs/api.md
Auto-merging deploy/olm-catalog/community-kubevirt-hyperconverged/1.13.1/manifests/kubevirt-hyperconverged-operator.v1.13.1.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in deploy/olm-catalog/community-kubevirt-hyperconverged/1.13.1/manifests/kubevirt-hyperconverged-operator.v1.13.1.clusterserviceversion.yaml
Auto-merging deploy/index-image/community-kubevirt-hyperconverged/1.13.1/manifests/kubevirt-hyperconverged-operator.v1.13.1.clusterserviceversion.yaml
Auto-merging deploy/cluster_role.yaml
Auto-merging controllers/hyperconverged/hyperconverged_controller.go
Auto-merging api/v1beta1/hyperconverged_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix issues with high availability detection

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

* add the missing "watch" permission for nodes. * make the status field a pointer to bool, to distinglish between false and field not set. * On mutation webhook, fix the eviction strategy if SNO becam HA. * fix an issue where the status field is not set if no node is added or deleted. * fix unit test (assert old HCO instead of HCO from client) * fix issue in the node controller, to ignore error if HCO is not present. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>

* validate-bundles: remove sudo usage (#3210) the make sanity github action has started to fail for using the sudo directive in this context. Signed-off-by: Oren Cohen <[email protected]> * Fix issues with high availability detection (#3205) * add the missing "watch" permission for nodes. * make the status field a pointer to bool, to distinglish between false and field not set. * On mutation webhook, fix the eviction strategy if SNO becam HA. * fix an issue where the status field is not set if no node is added or deleted. * fix unit test (assert old HCO instead of HCO from client) * fix issue in the node controller, to ignore error if HCO is not present. Signed-off-by: Nahshon Unna-Tsameret <[email protected]> --------- Signed-off-by: Oren Cohen <[email protected]> Signed-off-by: Nahshon Unna-Tsameret <[email protected]> Co-authored-by: Oren Cohen <[email protected]>

…3209) * validate-bundles: remove sudo usage (kubevirt#3210) the make sanity github action has started to fail for using the sudo directive in this context. Signed-off-by: Oren Cohen <[email protected]> * Fix issues with high availability detection (kubevirt#3205) * add the missing "watch" permission for nodes. * make the status field a pointer to bool, to distinglish between false and field not set. * On mutation webhook, fix the eviction strategy if SNO becam HA. * fix an issue where the status field is not set if no node is added or deleted. * fix unit test (assert old HCO instead of HCO from client) * fix issue in the node controller, to ignore error if HCO is not present. Signed-off-by: Nahshon Unna-Tsameret <[email protected]> --------- Signed-off-by: Oren Cohen <[email protected]> Signed-off-by: Nahshon Unna-Tsameret <[email protected]> Co-authored-by: Oren Cohen <[email protected]>

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 12, 2024

kubevirt-bot requested review from machadovilaca and sradco December 12, 2024 14:08

kubevirt-bot added the size/L label Dec 12, 2024

nunnatsa force-pushed the fix-ha branch 2 times, most recently from 5707fea to 0ceb18b Compare December 12, 2024 14:31

nunnatsa force-pushed the fix-ha branch from 0ceb18b to b675cec Compare December 12, 2024 15:51

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2024

nunnatsa force-pushed the fix-ha branch from b675cec to 421850d Compare December 15, 2024 05:57

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2024

nunnatsa force-pushed the fix-ha branch 3 times, most recently from fca9890 to da1d244 Compare December 15, 2024 07:16

nunnatsa force-pushed the fix-ha branch 2 times, most recently from 522e4b4 to a011b34 Compare December 15, 2024 10:05

nunnatsa force-pushed the fix-ha branch from a011b34 to 0505810 Compare December 15, 2024 10:42

orenc1 approved these changes Dec 16, 2024

View reviewed changes

kubevirt-bot assigned orenc1 Dec 16, 2024

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024

kubevirt-bot merged commit d863220 into kubevirt:main Dec 16, 2024
32 checks passed

nunnatsa deleted the fix-ha branch December 16, 2024 10:15

nunnatsa mentioned this pull request Dec 16, 2024

[Release 1.13] Fix issues with high availability detection #3209

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issues with high availability detection #3205

Fix issues with high availability detection #3205

nunnatsa commented Dec 12, 2024

coveralls commented Dec 12, 2024 •

edited

Loading

hco-bot commented Dec 12, 2024

kubevirt-bot commented Dec 12, 2024

hco-bot commented Dec 15, 2024

kubevirt-bot commented Dec 15, 2024

hco-bot commented Dec 15, 2024

kubevirt-bot commented Dec 15, 2024

hco-bot commented Dec 15, 2024

kubevirt-bot commented Dec 15, 2024

sonarqubecloud bot commented Dec 15, 2024

hco-bot commented Dec 15, 2024

kubevirt-bot commented Dec 15, 2024

hco-bot commented Dec 15, 2024

kubevirt-bot commented Dec 15, 2024

nunnatsa commented Dec 16, 2024

nunnatsa commented Dec 16, 2024

kubevirt-bot commented Dec 16, 2024

openshift-ci bot commented Dec 16, 2024 •

edited

Loading

hco-bot commented Dec 16, 2024

kubevirt-bot commented Dec 16, 2024

orenc1 left a comment

kubevirt-bot commented Dec 16, 2024

kubevirt-bot commented Dec 16, 2024

Fix issues with high availability detection #3205

Fix issues with high availability detection #3205

Conversation

nunnatsa commented Dec 12, 2024

coveralls commented Dec 12, 2024 • edited Loading

Pull Request Test Coverage Report for Build 12338107598

Details

💛 - Coveralls

hco-bot commented Dec 12, 2024

kubevirt-bot commented Dec 12, 2024

hco-bot commented Dec 15, 2024

kubevirt-bot commented Dec 15, 2024

hco-bot commented Dec 15, 2024

kubevirt-bot commented Dec 15, 2024

hco-bot commented Dec 15, 2024

kubevirt-bot commented Dec 15, 2024

sonarqubecloud bot commented Dec 15, 2024

Quality Gate passed

hco-bot commented Dec 15, 2024

kubevirt-bot commented Dec 15, 2024

hco-bot commented Dec 15, 2024

kubevirt-bot commented Dec 15, 2024

nunnatsa commented Dec 16, 2024

nunnatsa commented Dec 16, 2024

kubevirt-bot commented Dec 16, 2024

openshift-ci bot commented Dec 16, 2024 • edited Loading

hco-bot commented Dec 16, 2024

kubevirt-bot commented Dec 16, 2024

orenc1 left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Dec 16, 2024

kubevirt-bot commented Dec 16, 2024

coveralls commented Dec 12, 2024 •

edited

Loading

openshift-ci bot commented Dec 16, 2024 •

edited

Loading