[Release 1.13] Fix issues with high availability detection #3209
Conversation
kubevirt-bot
added
release-note-none
Pull Request Test Coverage Report for Build 12352688421Details
💛 - Coveralls |
|
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
the make sanity github action has started to fail for using the sudo directive in this context. Signed-off-by: Oren Cohen <[email protected]>
* add the missing "watch" permission for nodes. * make the status field a pointer to bool, to distinglish between false and field not set. * On mutation webhook, fix the eviction strategy if SNO becam HA. * fix an issue where the status field is not set if no node is added or deleted. * fix unit test (assert old HCO instead of HCO from client) * fix issue in the node controller, to ignore error if HCO is not present. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
nunnatsa
force-pushed
the
r113-fix-ha
branch
from
4003d97 to
4b893c6
Compare
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-operator-sdk-aws, hco-e2e-operator-sdk-gcp lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane passed |
|
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…3209) * validate-bundles: remove sudo usage (kubevirt#3210) the make sanity github action has started to fail for using the sudo directive in this context. Signed-off-by: Oren Cohen <[email protected]> * Fix issues with high availability detection (kubevirt#3205) * add the missing "watch" permission for nodes. * make the status field a pointer to bool, to distinglish between false and field not set. * On mutation webhook, fix the eviction strategy if SNO becam HA. * fix an issue where the status field is not set if no node is added or deleted. * fix unit test (assert old HCO instead of HCO from client) * fix issue in the node controller, to ignore error if HCO is not present. Signed-off-by: Nahshon Unna-Tsameret <[email protected]> --------- Signed-off-by: Oren Cohen <[email protected]> Signed-off-by: Nahshon Unna-Tsameret <[email protected]> Co-authored-by: Oren Cohen <[email protected]>
Signed-off-by: Oren Cohen <[email protected]>
Signed-off-by: Oren Cohen <[email protected]>
…) (#3202) * [release-1.12] Don't rely on InfraStructureTopology for infra HA (#3196) This is a manual backport of #3186 Signed-off-by: Oren Cohen <[email protected]> * [release-1.12] Fixes for HA, based on #3209 Signed-off-by: Oren Cohen <[email protected]> --------- Signed-off-by: Oren Cohen <[email protected]> Co-authored-by: kubevirt-bot <[email protected]>
What this PR does / why we need it:
Manual cherry-pick of #3205
Jira Ticket:
Release note: