Reconcile only a few values of KV configmap #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
|
/retest |
1 similar comment
|
/retest |
|
/ok-to-test |
kubevirt-bot
added
the
ok-to-test
vatsalparekh
suggested changes
May 21, 2020
kubevirt-bot
added
size/XXL
needs-rebase
nunnatsa
reviewed
May 27, 2020
pkg/controller/hyperconverged/hyperconverged_controller_test.go
Outdated
Show resolved
Hide resolved
|
Waiting for more unit tests |
kubevirt-bot
added
the
do-not-merge/hold
On upgrades only virtconfig.SmbiosConfigKey, virtconfig.MachineTypeKey and "selinuxLauncherType" should be manipulated. Everything else should keep its value to preserve user changes. This is going to happen only during HCO upgrades, during the lifecycle of the version the user is still allowed to edit them. - use const from config-map.go - set also debug.useEmulation according to KVM_EMULATION Signed-off-by: Simone Tiraboschi <[email protected]>
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
orenc1
approved these changes
May 27, 2020
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconcile only a few values of KV configmap and only on upgrades
On upgrades only virtconfig.SmbiosConfigKey, virtconfig.MachineTypeKey, virtconfig.SELinuxLauncherTypeKey and "debug.useEmulation"
should be manipulated.
Everything else should keep its value to preserve
user changes.
This is going to happen only during HCO upgrades,
during the lifecycle of the version the user
is still allowed to edit them.
Signed-off-by: Simone Tiraboschi [email protected]
Release note: