Use custom SELinux launcher type for virt-launcher #578
Conversation
stu-gott
commented
May 19, 2020
stu-gott
commented
kubevirt-bot
added
release-note
|
/cc @jean-edouard |
| @@ -472,7 +472,7 @@ func newKubeVirtConfigForCR(cr *hcov1alpha1.HyperConverged, namespace string) *c | |||
| Data: map[string]string{ | |||
| "feature-gates": "DataVolumes,SRIOV,LiveMigration,CPUManager,CPUNodeDiscovery,Sidecar", | |||
| "migrations": `{"nodeDrainTaintKey" : "node.kubernetes.io/unschedulable"}`, | |||
| "selinuxLauncherType": "spc_t", | |||
| "selinuxLauncherType": "virt_launcher.process", | |||
There was a problem hiding this comment.
Stu, do we also have to update it on existing deployments upgraded to this code?
Please see also: #577
There was a problem hiding this comment.
Yes we would. What does that entail?
There was a problem hiding this comment.
We don't want to reconcile anymore the whole configMap to preserve user set values (on feature-gates for instance) so we have to know which keys should be reconciled on upgrades.
|
@stu-gott: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Stu Gott <[email protected]>
|
@tiraboschi This PR has been rebased. It appears that changeset 27167a7 already accounts for the fact that this key needs to be re-evaluated upon update. Is there anything further to do with this besides the one-line change? |
|
All tests passed |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherry-pick release-2.4 |
|
@orenc1: new pull request created: #638 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
