Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] Dirty hack to unlock CI #749

Merged
merged 2 commits into from
Aug 14, 2020
Merged

[release-1.1] Dirty hack to unlock CI #749

merged 2 commits into from
Aug 14, 2020

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #747

/assign tiraboschi

NONE

@tiraboschi
Dirty hack to unlock CI
c7a35c3 
Signed-off-by: Simone Tiraboschi <[email protected]>
@kubevirt-bot kubevirt-bot mentioned this pull request Aug 13, 2020
Merged
@kubevirt-bot kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 13, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Aug 13, 2020
@kubevirt-bot kubevirt-bot requested review from djzager and orenc1 August 13, 2020 14:18
@tiraboschi
Copy link
Member

/test hco-e2e-azure
/test hco-e2e-upgrade-prev-aws

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: No presubmit jobs available for kubevirt/[email protected]

In response to this:

/test hco-e2e-azure
/test hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-aws

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: No presubmit jobs available for kubevirt/[email protected]

In response to this:

/test hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-prev-azure

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: No presubmit jobs available for kubevirt/[email protected]

In response to this:

/test hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-prev-aws

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: No presubmit jobs available for kubevirt/[email protected]

In response to this:

/test hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-prev-azure

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: No presubmit jobs available for kubevirt/[email protected]

In response to this:

/test hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-prev-aws

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: No presubmit jobs available for kubevirt/[email protected]

In response to this:

/test hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-prev-azure

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: No presubmit jobs available for kubevirt/[email protected]

In response to this:

/test hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-prev-aws

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: No presubmit jobs available for kubevirt/[email protected]

In response to this:

/test hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1
Copy link
Collaborator

orenc1 commented Aug 13, 2020

in last run, looks like:

  1. in azure, the hco version could not be extracted:
 + ./hack/retry.sh 10 30 'CMD=oc HCO_RESOURCE_NAME=kubevirt-hyperconverged HCO_NAMESPACE=kubevirt-hyperconverged TARGET_VERSION=100.0.0 hack/check_hco_version.sh'
CMD=oc HCO_RESOURCE_NAME=kubevirt-hyperconverged HCO_NAMESPACE=kubevirt-hyperconverged TARGET_VERSION=100.0.0 hack/check_hco_version.sh
++ oc get hco kubevirt-hyperconverged -n kubevirt-hyperconverged -o 'jsonpath={.status.versions[?(@.name=='\''operator'\'')].version}'
+ HCO_VERSION=
+ [[ 100.0.0 == '' ]]
> failed with exit code 1, waiting 30 seconds to retry...
  1. in aws, a difference between the SCCs before and after has been found:
 + dump_sccs_after
+ '[' oc == oc ']'
+ for f in '_out/scc/*${SCC_BEFORE_SUFFIX}'
++ basename --suffix=.yaml.before _out/scc/anyuid.yaml.before
+ SCCNAME=anyuid
+ echo -e '\n--- SCC anyuid ---'
--- SCC anyuid ---
+ oc get scc anyuid -o yaml
+ diff -I '^\s*generation:.*$' -I '^\s*resourceVersion:.*$' -I '^\s*time:.*$' _out/scc/anyuid.yaml.before _out/scc/anyuid.yaml.after
57d56
<       f:users: {}
61a61,67
>   - apiVersion: security.openshift.io/v1
>     fieldsType: FieldsV1
>     fieldsV1:
>       f:users: {}
>     manager: cdi-operator
>     operation: Update
>     time: "2020-08-13T19:35:38Z"
+ cleanup
+ rv=1
+ '[' x1 '!=' x0 ']'
+ echo 'Error during upgrade: exit status: 1'

i have no idea where is the flakiness is coming from.

@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-prev-azure

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: No presubmit jobs available for kubevirt/[email protected]

In response to this:

/test hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

in last run, looks like:

  1. in azure, the hco version could not be extracted:

this looks definitively flaky.

  1. in aws, a difference between the SCCs before and after has been found:
  • apiVersion: security.openshift.io/v1
    fieldsType: FieldsV1
    fieldsV1:
    f:users: {}
    manager: cdi-operator
    operation: Update

maybe this is expected:
hco-e2e-upgrade-prev-* is testing the upgrade from 1.0.0 -> 1.1.0 as in this PR.
Maybe the bug about scc modification has been fixed later on CDI side and we should ignore it on these CI lanes.

@tiraboschi
Copy link
Member

maybe this is expected:
hco-e2e-upgrade-prev-* is testing the upgrade from 1.0.0 -> 1.1.0 as in this PR.
Maybe the bug about scc modification has been fixed later on CDI side and we should ignore it on these CI lanes.

The PR on CDI side is here:
kubevirt/containerized-data-importer#1177
and it has been backported to 1.13 branch;

On that lane we are upgrading from docker.io/kubevirt/cdi-controller:v1.13.1 to -> docker.io/kubevirt/cdi-operator:v1.18.2

@tiraboschi
Copy link
Member

Ok,
CDI v1.13.1 is from Feb 25, PR #1177 on CDI has been merged on Apr 16 so it's not there for sure.
We should upgrade CDI to v1.13.4 on 1.0.0 CSV

@kubevirt-bot kubevirt-bot added size/S and removed lgtm Indicates that a PR is ready to be merged. size/XS labels Aug 13, 2020
@tiraboschi
Copy link
Member

#750 should let us re-enable scc test on N-1 upgrade

@tiraboschi
Skipping SCC check on 1.0.0 -> 1.1.0+PR
7e605c2 
ignoring scc check on 1.0.0 -> 1.1.0+PR because
in 1.0.0 we ship CDI v1.13.1 which was bugged

Signed-off-by: Simone Tiraboschi <[email protected]>
@tiraboschi tiraboschi force-pushed the cherry-pick-747-to-release-1.1 branch from 2607a72 to 7e605c2 Compare August 13, 2020 22:39
@tiraboschi
Copy link
Member

on hco-e2e-upgrade-azure is failing with:

  - lastHeartbeatTime: "2020-08-14T00:15:28Z"
    lastTransitionTime: "2020-08-13T23:46:10Z"
    message: 'NetworkAddonsConfig is progressing: Deployment "kubevirt-hyperconverged/kubemacpool-mac-controller-manager"
      is not available (awaiting 1 nodes)'
    reason: NetworkAddonsConfigProgressing
    status: "False"
    type: Upgradeable

which exactly the issue we aim to fix.

@tiraboschi
Copy link
Member

/retest

@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-azure

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: No presubmit jobs available for kubevirt/[email protected]

In response to this:

/test hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2020
@kubevirt-bot kubevirt-bot merged commit 87790f3 into kubevirt:release-1.1 Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 orenc1 approved these changes

@djzager djzager Awaiting requested review from djzager

Assignees

@tiraboschi tiraboschi

@orenc1 orenc1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubevirt-bot @ovirt-infra @tiraboschi @orenc1