Consume operator-sdk 1.1.0 #898

tiraboschi · 2020-10-23T09:18:21Z

operator-sdk >= v1.0.0 introduces various not backward
compatible changes.
Aligning with that.

See:
https://v1-1-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
https://v1-1-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.1.0/
for the migrations guides.

Relevant changes in the operator sdk:

Removed package pkg/k8sutil
Removed packages pkg/kube-metrics and pkg/metrics
Removed package pkg/ready
Package version is no longer public
pkg/log/zap is no longer a public API

Moving from Leader-for-life to Leader-with-lease from
controller runtime to avoid a deadlock on rolling upgrades.

Signed-off-by: Simone Tiraboschi [email protected]

Release note:

Consume operator-sdk 1.1.0

ovirt-infra · 2020-10-23T09:21:03Z

All tests passed

ovirt-infra · 2020-10-23T09:24:03Z

All tests passed

tiraboschi · 2020-10-23T14:56:01Z

/hold

ovirt-infra · 2020-10-29T11:09:41Z

All tests passed

hco-bot · 2020-10-29T12:56:24Z

hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2020-10-29T12:56:28Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ovirt-infra · 2020-10-29T13:24:46Z

All tests passed

ovirt-infra · 2020-10-29T14:54:11Z

All tests passed

ovirt-infra · 2020-10-29T15:08:13Z

All tests passed

ovirt-infra · 2020-10-29T16:09:11Z

All tests passed

ovirt-infra · 2020-10-30T07:53:43Z

All tests passed

ovirt-infra · 2020-10-30T08:38:45Z

All tests passed

ovirt-infra · 2020-10-30T08:49:59Z

All tests passed

ovirt-infra · 2020-10-30T12:31:45Z

All tests passed

ovirt-infra · 2020-10-30T12:58:43Z

All tests passed

tiraboschi · 2020-10-30T15:21:02Z

/retest

ovirt-infra · 2020-10-30T16:01:21Z

All tests passed

tiraboschi · 2020-10-30T20:23:38Z

/retest

tiraboschi · 2020-10-31T08:40:25Z

/retest

tiraboschi · 2020-11-01T17:57:52Z

/retest

tiraboschi · 2020-11-02T08:14:25Z

/retest

ovirt-infra · 2020-11-02T11:39:29Z

All tests passed

ovirt-infra · 2020-11-02T13:54:59Z

All tests passed

ovirt-infra · 2020-11-02T22:36:02Z

All tests passed

tiraboschi · 2020-11-03T15:13:43Z

I'd expect openshift/release#13355 to fix the issues with hco-e2e-image-index-* lanes
/retest

tiraboschi · 2020-11-03T16:57:31Z

hco-e2e-image-index-* got indeed fixed by openshift/release#13355
I fear that we instead have a real bug on the upgrade

on https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/kubevirt_hyperconverged-cluster-operator/898/pull-ci-kubevirt-hyperconverged-cluster-operator-master-hco-e2e-upgrade-prev-aws/1323644550668881920

for instance, we ended up with the old version of the operator and the new one running at the same time:

hco-operator-5d9547f8b-rhd7k 1/1 Running 0 13m
hco-operator-9b4c8c688-kr6pq 0/1 Running 0 8m31s

With the new version not really able to start due to:

{"level":"info","ts":1604419697.3071926,"logger":"leader","msg":"Found existing lock","LockOwner":"hco-operator-5d9547f8b-rhd7k"}
{"level":"info","ts":1604419697.328862,"logger":"leader","msg":"Not the leader. Waiting."}

ovirt-infra · 2020-11-03T17:30:31Z

All tests passed

ovirt-infra · 2020-11-03T21:52:58Z

All tests passed

ovirt-infra · 2020-11-04T07:12:25Z

All tests passed

tiraboschi · 2020-11-04T07:54:21Z

/unhold

nunnatsa

Two small comments/questions

nunnatsa · 2020-11-04T09:31:23Z

cmd/hyperconverged-cluster-operator/main.go

@@ -73,15 +59,16 @@ func main() {
 	// implementing the logr.Logger interface. This logger will
 	// be propagated through the whole operator, generating
 	// uniform and structured logs.
-	logf.SetLogger(zap.Logger())
+	development_mode_logger := false // use a production logger


Why do we need this variable? what about using an environment variable (default = false) for that?

sigs.k8s.io/controller-runtime/pkg/log already provides CLI options, using them instead of an hardcoded value

But why use a boolean parameter just in order to use it as a value in the next line?

Why not just

logf.SetLogger(zap.New(zap.UseDevMode(false)))

sorry, I commented before pushing.
the last version is just logf.SetLogger(zap.New(zap.UseFlagOptions(zopts))) to consume the CLI flags parsed on zopts

cmd/hyperconverged-cluster-operator/main.go

operator-sdk >= v1.0.0 introduces various not backward compatible changes. Aligning with that. See: https://v1-1-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/ https://v1-1-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.1.0/ for the migrations guides. Relevant changes in the operator sdk: - Removed package pkg/k8sutil - Removed packages pkg/kube-metrics and pkg/metrics - Removed package pkg/ready - Package version is no longer public - pkg/log/zap is no longer a public API Moving from Leader-for-life to Leader-with-lease from controller runtime to avoid a deadlock on rolling upgrades. Signed-off-by: Simone Tiraboschi <[email protected]>

ovirt-infra · 2020-11-04T14:27:25Z

All tests passed

openshift-merge-robot · 2020-11-04T16:19:10Z

@tiraboschi: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/hco-e2e-upgrade-azure	8683d27bfa793f80ed42702c593f7eff50376a1e	link	`/test hco-e2e-upgrade-azure`
ci/prow/hco-e2e-aws	`79800a0`	link	`/test hco-e2e-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nunnatsa · 2020-11-04T16:48:56Z

/override-bot

hco-bot · 2020-11-04T16:49:36Z

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-aws
hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure
hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

kubevirt-bot · 2020-11-04T16:49:44Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-aws, ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-upgrade-azure, ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-aws
hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure
hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2020-11-04T16:50:16Z

/lgtm
/approve

kubevirt-bot · 2020-11-04T16:50:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Remove a small hack introduced only to be able to easily test #898 on CI Signed-off-by: Simone Tiraboschi <[email protected]>

tiraboschi requested review from yuvalturg, orenc1 and nunnatsa October 23, 2020 09:18

kubevirt-bot requested a review from sradco October 23, 2020 09:18

tiraboschi changed the title ~~WIP: Consume operator-sdk 1.1.0~~ Consume operator-sdk 1.1.0 Nov 4, 2020

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2020

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2020

nunnatsa reviewed Nov 4, 2020

View reviewed changes

kubevirt-bot assigned nunnatsa Nov 4, 2020

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020

kubevirt-bot merged commit b8c2a24 into kubevirt:master Nov 4, 2020

tiraboschi mentioned this pull request Nov 4, 2020

Remove a CI hack #916

Merged

kubevirt-bot pushed a commit that referenced this pull request Nov 5, 2020

Remove a CI hack (#916)

0d0b2f8

Remove a small hack introduced only to be able to easily test #898 on CI Signed-off-by: Simone Tiraboschi <[email protected]>

Consume operator-sdk 1.1.0 #898

Consume operator-sdk 1.1.0 #898

Conversation

tiraboschi commented Oct 23, 2020 • edited Loading

ovirt-infra commented Oct 23, 2020

ovirt-infra commented Oct 23, 2020

tiraboschi commented Oct 23, 2020

ovirt-infra commented Oct 29, 2020

hco-bot commented Oct 29, 2020

kubevirt-bot commented Oct 29, 2020

ovirt-infra commented Oct 29, 2020

ovirt-infra commented Oct 29, 2020

ovirt-infra commented Oct 29, 2020

ovirt-infra commented Oct 29, 2020

ovirt-infra commented Oct 30, 2020

ovirt-infra commented Oct 30, 2020

ovirt-infra commented Oct 30, 2020

ovirt-infra commented Oct 30, 2020

ovirt-infra commented Oct 30, 2020

tiraboschi commented Oct 30, 2020

ovirt-infra commented Oct 30, 2020

tiraboschi commented Oct 30, 2020

tiraboschi commented Oct 31, 2020

tiraboschi commented Nov 1, 2020

tiraboschi commented Nov 2, 2020

ovirt-infra commented Nov 2, 2020

ovirt-infra commented Nov 2, 2020

ovirt-infra commented Nov 2, 2020

tiraboschi commented Nov 3, 2020

tiraboschi commented Nov 3, 2020 • edited Loading

ovirt-infra commented Nov 3, 2020

ovirt-infra commented Nov 3, 2020

ovirt-infra commented Nov 4, 2020

tiraboschi commented Nov 4, 2020

nunnatsa left a comment

Choose a reason for hiding this comment

nunnatsa Nov 4, 2020

Choose a reason for hiding this comment

tiraboschi Nov 4, 2020

Choose a reason for hiding this comment

nunnatsa Nov 4, 2020

Choose a reason for hiding this comment

tiraboschi Nov 4, 2020

Choose a reason for hiding this comment

ovirt-infra commented Nov 4, 2020

openshift-merge-robot commented Nov 4, 2020

nunnatsa commented Nov 4, 2020

hco-bot commented Nov 4, 2020

kubevirt-bot commented Nov 4, 2020

nunnatsa commented Nov 4, 2020

kubevirt-bot commented Nov 4, 2020

tiraboschi commented Oct 23, 2020 •

edited

Loading

tiraboschi commented Nov 3, 2020 •

edited

Loading