Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a CI hack #916

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Remove a CI hack #916

merged 1 commit into from
Nov 5, 2020

Conversation

tiraboschi
Copy link
Member

Remove a small hack introduced only to be able
to easily test #898 on CI

Signed-off-by: Simone Tiraboschi [email protected]

Release note:

NONE

Remove a small hack introduced only to be able
to easily test #898 on CI

Signed-off-by: Simone Tiraboschi <[email protected]>
@tiraboschi tiraboschi requested review from orenc1 and nunnatsa November 4, 2020 17:20
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Nov 4, 2020
@kubevirt-bot kubevirt-bot requested a review from sradco November 4, 2020 17:21
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@ovirt-infra
Copy link

All tests passed

@nunnatsa
Copy link
Collaborator

nunnatsa commented Nov 5, 2020

/retest

@openshift-merge-robot
Copy link
Collaborator

openshift-merge-robot commented Nov 5, 2020

@tiraboschi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-azure ea6a8ab link /test hco-e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Nov 5, 2020

hco-e2e-aws passed.
/override ci/prow/hco-e2e-azure

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-azure

In response to this:

hco-e2e-aws passed.
/override ci/prow/hco-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 0d0b2f8 into kubevirt:master Nov 5, 2020
@tiraboschi tiraboschi deleted the remove_ci_hack branch November 5, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants