Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Change default values of env vars #36

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Nov 30, 2022

Use empty strings as default values for the env vars.
The Zone manager will set the defaults accordingly.
This allows to deploy the manifest as is.

Since CNAO CR also doesn't have values, it will align the e2e test to
work when running from CNAO (using default values).

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Nov 30, 2022
@dteplits
Copy link
Contributor

dteplits commented Dec 1, 2022

Use empty strings as default values for the env vars. The Zone manager will set the defaults accordingly. This allows the deploy the manifest as is.

None

I guess you meant "This allows to deploy the manifest as is."

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 1, 2022

Right thanks, fixed and rebased

@dteplits
Copy link
Contributor

dteplits commented Dec 1, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2022
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@oshoval
Copy link
Collaborator Author

oshoval commented Dec 6, 2022

Rebase
adjust the test accordingly

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 7, 2022

@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2022
Use empty strings as default values for the env vars.
The Zone manager will set the defaults accordingly.
This allows to deploy the manifest as is.

Signed-off-by: Or Shoval <[email protected]>
@oshoval oshoval marked this pull request as ready for review December 7, 2022 14:10
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2022
@oshoval
Copy link
Collaborator Author

oshoval commented Dec 7, 2022

Weird that when going back and forth from draft the git actions aren't triggered

@oshoval oshoval closed this Dec 7, 2022
@oshoval oshoval reopened this Dec 7, 2022
@oshoval
Copy link
Collaborator Author

oshoval commented Dec 7, 2022

Closed reopen fixed the git actions

@AlonaKaplan
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@AlonaKaplan
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@kubevirt-bot kubevirt-bot merged commit 98b0eda into kubevirt:main Dec 7, 2022
@oshoval
Copy link
Collaborator Author

oshoval commented Dec 7, 2022

Thanks
When you can please create a tag, so we can consume it on CNAO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants