-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest: Change default values of env vars #36
Conversation
I guess you meant "This allows to deploy the manifest as is." |
Right thanks, fixed and rebased |
/lgtm |
Rebase |
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubesecondarydns/36/pull-kubesecondarydns-e2e-k8s/1600149829063806976 /retest |
e6511a9
to
f52fc3e
Compare
Use empty strings as default values for the env vars. The Zone manager will set the defaults accordingly. This allows to deploy the manifest as is. Signed-off-by: Or Shoval <[email protected]>
Weird that when going back and forth from draft the git actions aren't triggered |
Closed reopen fixed the git actions |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlonaKaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Thanks |
Use empty strings as default values for the env vars.
The Zone manager will set the defaults accordingly.
This allows to deploy the manifest as is.
Since CNAO CR also doesn't have values, it will align the e2e test to
work when running from CNAO (using default values).