Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: add search function #446

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Nov 18, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:
site: add search function

Which issue(s) this PR fixes:
Fixes #380

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

site: now user can search in website https://kurator.dev/

image

image

Copy link

netlify bot commented Nov 18, 2023

Deploy Preview for kurator-dev ready!

Name Link
🔨 Latest commit b06d183
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/655ab9680284c7000817a589
😎 Deploy Preview https://deploy-preview-446--kurator-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Xieql
Copy link
Contributor Author

Xieql commented Nov 18, 2023

/kind documentation

@zirain
Copy link
Contributor

zirain commented Nov 18, 2023

/lgtm

@hzxuzhonghu
Copy link
Member

goog work

/lgtm

docs/config.toml Outdated
@@ -60,6 +60,17 @@ path = "github.com/google/docsy/dependencies"

[params]
copyright = "The Kurator Authors"

# Google Custom Search Engine ID. Remove or comment out to disable search.
#gcs_engine_id = "d72aa9b2712488cc3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Xieql
Copy link
Contributor Author

Xieql commented Nov 20, 2023

/label tide/merge-method-squash

@kurator-bot kurator-bot merged commit 5b59508 into kurator-dev:main Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Search Capability to Documentation
4 participants