Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rollback during Node Table COPY #4467

Merged
merged 28 commits into from
Dec 2, 2024

Update splitSlots so behaviour is same as before nextChainedSlot() re…

cec96e5
Select commit
Loading
Failed to load commit list.
Merged

Fix rollback during Node Table COPY #4467

Update splitSlots so behaviour is same as before nextChainedSlot() re…
cec96e5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 2, 2024 in 1s

87.35% (target 80.00%)

View this Pull Request on Codecov

87.35% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 95.14349% with 22 lines in your changes missing coverage. Please review.

Project coverage is 87.35%. Comparing base (f5224d7) to head (cec96e5).

Files with missing lines Patch % Lines
src/storage/store/node_table.cpp 95.37% 5 Missing ⚠️
src/storage/store/rel_table_data.cpp 93.18% 3 Missing ⚠️
test/copy/copy_test.cpp 95.89% 0 Missing and 3 partials ⚠️
src/include/common/mask.h 50.00% 2 Missing ⚠️
src/include/storage/store/column.h 0.00% 2 Missing ⚠️
src/include/storage/store/rel_table_data.h 50.00% 2 Missing ⚠️
src/storage/store/list_column.cpp 66.66% 2 Missing ⚠️
src/include/storage/store/node_table.h 50.00% 1 Missing ⚠️
src/storage/store/chunked_node_group.cpp 85.71% 1 Missing ⚠️
src/storage/store/rel_table.cpp 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4467      +/-   ##
==========================================
+ Coverage   87.26%   87.35%   +0.09%     
==========================================
  Files        1357     1358       +1     
  Lines       56772    57078     +306     
  Branches     7083     7109      +26     
==========================================
+ Hits        49541    49863     +322     
+ Misses       7069     7050      -19     
- Partials      162      165       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov