feat/add-mAttachTenant #31

rolljee · 2021-03-02T16:53:27Z

Add mAttachTenant methods

rolljee · 2021-03-03T08:07:45Z

My bad, I forgot to write the documentation

doc/1/controllers/sensor/mattach-tenant/index.md

features/SensorController.feature

lib/controllers/SensorController.ts

Aschen

The import action should returns the list of success and errors to allows the users to act accordingly and modify the input.

For example if every sensors cannot be attached to tenants for some reason, the one who could should still be attached and proper response should be sent to user.

This will allows to import a CSV, having some sensor attached but errors with others, correct the errors lines and re-import the same CSV to import the corrected lines.
Trying to re-attach a sensor to the same tenant should then not be considered as an error.

Finally, a strict option could be interesting to throw an error if any of the line contains an error (the errors must be checked before import)

You can look at omniscient code for an example:

features/SensorController.feature

lib/controllers/SensorController.ts

doc/1/controllers/sensor/mattach-tenant/index.md

lib/services/SensorService.ts

Co-authored-by: Michele Leo <[email protected]>

Co-authored-by: Adrien Maret <[email protected]>

lib/controllers/SensorController.ts

lib/services/SensorService.ts

lib/types/SensorContent.ts

…th bulk import and Kuzzle limit

lib/services/SensorService.ts

…for it

Aschen

Can you add a Laius about the format ? Users will be interested to know that they can use CSV for example (it's a very bankable feature in avv)

Aschen · 2021-03-09T09:36:00Z

doc/1/guides/sensors/index.md

@@ -110,6 +110,12 @@ Sensors can be attached to tenant by using the [device-manager/sensor:attach](/k

 When attached, the sensor document is copied inside the `sensors` collection of the tenant index.

+## Attach to multiple tenant
+
+Multiple differents Sensors can also be attached to multiple defferents tenant by using the [device-manager/sensor:attach](/kuzzle-iot-platform/device-manager/1/controllers/sensor/mattach-tenant) API action.


Suggested change

Multiple differents Sensors can also be attached to multiple defferents tenant by using the [device-manager/sensor:attach](/kuzzle-iot-platform/device-manager/1/controllers/sensor/mattach-tenant) API action.

Multiple different Sensors can also be attached to multiple different tenant by using the [device-manager/sensor:mAttach](/kuzzle-iot-platform/device-manager/1/controllers/sensor/m-attach-tenant) API action.

The file name must be changed accordingly

Aschen · 2021-03-09T09:40:47Z

lib/services/SensorService.ts

-   'sensors',
-   sensor._id,
-   { assetId });
+    const writeMany = async (start: number, end: number) => {


Very clever design 👍

…le name

Aschen

Last change and LGTM 👍

Aschen · 2021-03-10T09:55:07Z

doc/1/guides/sensors/index.md

@@ -112,9 +112,11 @@ When attached, the sensor document is copied inside the `sensors` collection of

 ## Attach to multiple tenant

-Multiple differents Sensors can also be attached to multiple defferents tenant by using the [device-manager/sensor:attach](/kuzzle-iot-platform/device-manager/1/controllers/sensor/mattach-tenant) API action.
+Multiple different Sensors can also be attached to multiple defferents tenant by using the [device-manager/sensor:mAttach](/kuzzle-iot-platform/device-manager/1/controllers/sensor/mAttach) API action.


File name should be in kebab-case (while API action is in camelCase)

Suggested change

Multiple different Sensors can also be attached to multiple defferents tenant by using the [device-manager/sensor:mAttach](/kuzzle-iot-platform/device-manager/1/controllers/sensor/mAttach) API action.

Multiple different Sensors can also be attached to multiple defferents tenant by using the [device-manager/sensor:mAttach](/kuzzle-iot-platform/device-manager/1/controllers/sensor/m-attach) API action.

I'll update files accordingly 👍

doc/1/controllers/sensor/m-attach/index.md

features/step_definitions/sensor-controller-steps.js

Aschen · 2021-03-10T11:09:48Z

lib/controllers/SensorController.ts

@@ -41,6 +45,10 @@ export class SensorController extends CRUDController {
          handler: this.attachTenant.bind(this),
          http: [{ verb: 'put', path: 'device-manager/:index/sensors/:_id/_attach' }]
        },
+        mAttachTenant: {


I'm confused, the action name is mAttach or mAttachTenant at the end ? 😅

Stick to mAttach, sorry about that

Co-authored-by: Adrien Maret <[email protected]>

doc/1/controllers/sensor/m-attach/index.md

Aschen · 2021-03-10T15:05:36Z

LGTM 👍

Co-authored-by: Adrien Maret <[email protected]>

rolljee added 4 commits March 2, 2021 17:51

feat/add-mAttachTenant

aeb5c04

Lint

5550d7e

Lint

573245b

Remove ?. syntax

469efd1

rolljee marked this pull request as draft March 3, 2021 08:15

Add documentation

bd1c5c4

rolljee marked this pull request as ready for review March 3, 2021 09:39

Leodau reviewed Mar 3, 2021

View reviewed changes

doc/1/controllers/sensor/mattach-tenant/index.md Outdated Show resolved Hide resolved

Leodau suggested changes Mar 3, 2021

View reviewed changes

Aschen suggested changes Mar 3, 2021

View reviewed changes

rolljee and others added 9 commits March 3, 2021 14:10

Update doc/1/controllers/sensor/mattach-tenant/index.md

529e622

Co-authored-by: Michele Leo <[email protected]>

Update features/SensorController.feature

b798874

Co-authored-by: Michele Leo <[email protected]>

Update lib/controllers/SensorController.ts

27ba94f

Co-authored-by: Michele Leo <[email protected]>

Update lib/controllers/SensorController.ts

23fa990

Co-authored-by: Michele Leo <[email protected]>

Update lib/controllers/SensorController.ts

259b5f4

Co-authored-by: Michele Leo <[email protected]>

Update lib/controllers/SensorController.ts

b896327

Co-authored-by: Michele Leo <[email protected]>

Update lib/controllers/SensorController.ts

98410a6

Co-authored-by: Adrien Maret <[email protected]>

Update lib/controllers/SensorController.ts

db06c76

Co-authored-by: Adrien Maret <[email protected]>

Requested changes

cf1f49c

Leodau assigned rolljee Mar 4, 2021

Leodau added backend kuzzle-iot-platform labels Mar 4, 2021

Leodau approved these changes Mar 4, 2021

View reviewed changes

lib/controllers/SensorController.ts Outdated Show resolved Hide resolved

lib/controllers/SensorController.ts Outdated Show resolved Hide resolved

Leodau linked an issue Mar 4, 2021 that may be closed by this pull request

Add bulk API actions #16

Closed

rolljee added 2 commits March 4, 2021 15:36

Add function to parse mRequest

bd42756

Rename a function

a02037b

rolljee mentioned this pull request Mar 4, 2021

Feat/add m detach #33

Merged

3 tasks

merge 1-dev

96515b9

rolljee force-pushed the 1-dev branch from 1dbefcd to 7669f06 Compare March 5, 2021 16:57

rolljee added 2 commits March 8, 2021 11:39

Fix issue with mAttatchSensors tests

50d4ecd

Remove debug leftover

ae0ac60

Aschen suggested changes Mar 8, 2021

View reviewed changes

rolljee added 4 commits March 8, 2021 13:40

Fix tests

8fb0279

Use global.kuzzle.config.limits.documentsWriteCount to avoid issue wi…

10fae65

…th bulk import and Kuzzle limit

Requested changes

6b560c2

Make writeToDatabase function more generic

e04e093

Aschen suggested changes Mar 8, 2021

View reviewed changes

lib/services/SensorService.ts Outdated Show resolved Hide resolved

enhancement of writeToDatabase using kuzzle limits & Add custom test …

d442755

…for it

rolljee requested a review from Aschen March 9, 2021 08:21

Update docs & add a part in the guide for mAttach

c469729

Aschen suggested changes Mar 9, 2021

View reviewed changes

Aschen reviewed Mar 9, 2021

View reviewed changes

rolljee added 2 commits March 10, 2021 09:44

merge 1-dev

453b230

Adds laius about format, correct some spelling mistakes and modify fi…

b666fe1

…le name

rolljee requested review from Aschen and Leodau March 10, 2021 08:57

Aschen suggested changes Mar 10, 2021

View reviewed changes

Update docs and rename mAttach to m-attach in directory structure

14dfe31

Aschen suggested changes Mar 10, 2021

View reviewed changes

rolljee and others added 5 commits March 10, 2021 15:40

Update doc/1/controllers/sensor/m-attach/index.md

de92bb7

Co-authored-by: Adrien Maret <[email protected]>

Update doc/1/controllers/sensor/m-attach/index.md

465110f

Co-authored-by: Adrien Maret <[email protected]>

Update doc/1/controllers/sensor/m-attach/index.md

7e0e2cb

Co-authored-by: Adrien Maret <[email protected]>

fix left mAttachtenant to mAttach

ac9ffb1

Fix wrong identation

eb706cd

Aschen approved these changes Mar 10, 2021

View reviewed changes

doc/1/controllers/sensor/m-attach/index.md Outdated Show resolved Hide resolved

Update doc/1/controllers/sensor/m-attach/index.md

08694c0

Co-authored-by: Adrien Maret <[email protected]>

Aschen merged commit 144a8fd into 1-dev Mar 16, 2021

Aschen deleted the feat/add-m-attach-tenant branch March 16, 2021 08:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/add-mAttachTenant #31

feat/add-mAttachTenant #31

rolljee commented Mar 2, 2021

rolljee commented Mar 3, 2021

Aschen left a comment

Aschen left a comment

Aschen Mar 9, 2021

Aschen Mar 9, 2021 •

edited

Loading

Aschen left a comment

Aschen Mar 10, 2021

rolljee Mar 10, 2021

Aschen Mar 10, 2021

rolljee Mar 10, 2021

Aschen commented Mar 10, 2021

	Multiple differents Sensors can also be attached to multiple defferents tenant by using the [device-manager/sensor:attach](/kuzzle-iot-platform/device-manager/1/controllers/sensor/mattach-tenant) API action.
	Multiple different Sensors can also be attached to multiple different tenant by using the [device-manager/sensor:mAttach](/kuzzle-iot-platform/device-manager/1/controllers/sensor/m-attach-tenant) API action.

feat/add-mAttachTenant #31

feat/add-mAttachTenant #31

Conversation

rolljee commented Mar 2, 2021

rolljee commented Mar 3, 2021

Aschen left a comment

Choose a reason for hiding this comment

Aschen left a comment

Choose a reason for hiding this comment

Aschen Mar 9, 2021

Choose a reason for hiding this comment

Aschen Mar 9, 2021 • edited Loading

Choose a reason for hiding this comment

Aschen left a comment

Choose a reason for hiding this comment

Aschen Mar 10, 2021

Choose a reason for hiding this comment

rolljee Mar 10, 2021

Choose a reason for hiding this comment

Aschen Mar 10, 2021

Choose a reason for hiding this comment

rolljee Mar 10, 2021

Choose a reason for hiding this comment

Aschen commented Mar 10, 2021

Aschen Mar 9, 2021 •

edited

Loading