Feat/add m detach #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michele Leo <[email protected]>
Co-authored-by: Michele Leo <[email protected]>
Co-authored-by: Michele Leo <[email protected]>
Co-authored-by: Michele Leo <[email protected]>
Co-authored-by: Michele Leo <[email protected]>
Co-authored-by: Michele Leo <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Closed
|
Next works is about making tests steps more generic to tests m* Queries |
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
Co-authored-by: Adrien Maret <[email protected]>
…kuzzle documents limits
Aschen
suggested changes
Mar 15, 2021
| @@ -0,0 +1,52 @@ | |||
| const { When, Then } = require('cucumber'); | |||
There was a problem hiding this comment.
Wrong indentation for this file. It should be 2 spaces
lib/controllers/SensorController.ts
Outdated
| @@ -76,21 +76,21 @@ export class SensorController extends CRUDController { | |||
| const tenantId = this.getIndex(request); | |||
| const sensorId = this.getId(request); | |||
|
|
|||
| const document = { tenant: tenantId, id: sensorId }; | |||
| const document = { tenantId: tenantId, sensorId: sensorId }; | |||
| @@ -0,0 +1,89 @@ | |||
| --- | |||
There was a problem hiding this comment.
This file should be name m-detach
| --- | ||
| code: true | ||
| type: page | ||
| title: detach |
There was a problem hiding this comment.
Suggested change
| title: detach | |
| title: mDetach |
| description: Detach multiple sensors from multiple tenants | ||
| --- | ||
|
|
||
| # detach |
There was a problem hiding this comment.
Suggested change
| # detach | |
| # mDetach |
| ``` js | ||
| { | ||
| // Using JSON | ||
| "records" [{ |
There was a problem hiding this comment.
The mDetach action should only takes an array of sensorId
lib/services/SensorService.ts
Outdated
| async detach (sensor: Sensor) { | ||
| if (! sensor._source.tenantId) { | ||
| throw new BadRequestError(`Sensor "${sensor._id}" is not attached to a tenant`); | ||
| async mDetach (sensors: Sensor[], bulkData: SensorBulkContent[], isStrict: boolean) { |
There was a problem hiding this comment.
Same comment as for mAttach, the option should be passed inside an object
lib/services/SensorService.ts
Outdated
| }) | ||
|
|
||
| results.successes.concat(successes); | ||
| results.errors.concat(errors); |
There was a problem hiding this comment.
You are not returning anything?
Aschen
approved these changes
Mar 18, 2021
lib/services/SensorService.ts
Outdated
| const results = { | ||
| errors: [], | ||
| successes: [], | ||
| }; | ||
|
|
||
| console.log('BBBBB', JSON.stringify(documents)); |
lib/services/SensorService.ts
Outdated
| @@ -81,27 +81,37 @@ export class SensorService { | |||
| return results; | |||
| } | |||
|
|
|||
| async mDetach (sensors: Sensor[], bulkData: SensorBulkContent[], isStrict: boolean) { | |||
| async mDetach (sensors: Sensor[], bulkData: SensorBulkContent[], { strict }) { | |||
| console.log('CCCC', JSON.stringify(sensors)); | |||
Aschen
suggested changes
Mar 18, 2021
| // Using JSON | ||
| "sensorIds" ["test-id"], | ||
| // Using CSV syntax | ||
| "csv": "sensorIds\ntest-id" |
There was a problem hiding this comment.
The column name should be sensorId since it's a csv file.
Each line will contain 1 sensor ID
There was a problem hiding this comment.
Indeed, you're right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also this PR adds mDetachTenant methods