fix(azure): use object id instead of principal id #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for the `application_password` resource says: >`application_object_id` - (Required) The Object ID of the Application >for which this password should be created. Changing this field forces >a new resource to be created. https://registry.terraform.io/providers/hashicorp/azuread/latest/docs/resources/application_password#application_object_id We were using the wrong id. 🤦 Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/az/fix
branch
from
aa35740 to
e15789e
Compare
afiune
commented
Sep 8, 2020
| @@ -98,7 +98,7 @@ resource "azurerm_role_assignment" "grant_reader_role_to_subscriptions" { | |||
| count = var.create ? length(data.azurerm_subscriptions.available.subscriptions) : 0 | |||
| scope = "/subscriptions/${data.azurerm_subscriptions.available.subscriptions[count.index].subscription_id}" | |||
|
|
|||
| principal_id = azuread_service_principal.lacework[0].id | |||
| principal_id = local.service_principal_id | |||
There was a problem hiding this comment.
This is just using the service principal id defined above in the locals {} block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the
application_passwordresource says:https://registry.terraform.io/providers/hashicorp/azuread/latest/docs/resources/application_password#application_object_id
We were using the wrong id. 🤦
Signed-off-by: Salim Afiune Maya [email protected]