Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.2.0 #77

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Release v0.2.0 #77

merged 1 commit into from
Sep 11, 2020

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Sep 11, 2020

Release Notes

Another day, another release. These are the release notes for the version v0.2.0.

Breaking Changes

Users now MUST provide ARN for IAM Role and/or S3 bucket

If you are using one of the use_existing_iam_role or use_existing_cloudtrail variables,
you will have to update your Terraform plans to pass not only the name but the ARN as well.

Existing IAM Role

Before:

provider "lacework" { }

provider "aws" { }

module "aws_cloudtrail" {
	source = "git::https://github.com/lacework/terraform-provisioning.git//aws/modules/cloudtrail?ref=master"

	# Use an existing IAM role
	use_existing_iam_role = true
	iam_role_name         = "lw-existing-role"
	iam_role_external_id  = "1GrDkEZV5VJ@=nLm"
}

Now:

provider "lacework" { }

provider "aws" { }

module "aws_cloudtrail" {
	source = "git::https://github.com/lacework/terraform-provisioning.git//aws/modules/cloudtrail?ref=master"

	# Use an existing IAM role
	use_existing_iam_role = true
	iam_role_arn          = "arn:aws:iam::123456789012:role/lw-existing-role"  // <-- NEW! Must be provided
	iam_role_name         = "lw-existing-role"
	iam_role_external_id  = "1GrDkEZV5VJ@=nLm"
}

Existing CloudTrail

Before:

provider "lacework" { }

provider "aws" { }

module "aws_cloudtrail" {
	source = "git::https://github.com/lacework/terraform-provisioning.git//aws/modules/cloudtrail?ref=master"

	# Use an existing CloudTrail
	use_existing_cloudtrail    = true
	bucket_name                = "lacework-ct-bucket-8805c0bf"
	sns_topic_name             = "lacework-ct-sns-8805c0bf"
}

Now:

provider "lacework" { }

provider "aws" { }

module "aws_cloudtrail" {
	source = "git::https://github.com/lacework/terraform-provisioning.git//aws/modules/cloudtrail?ref=master"

	# Use an existing CloudTrail
	use_existing_cloudtrail    = true
	bucket_arn                 = "arn:aws:s3:::lacework-ct-bucket-8805c0bf"  // <-- NEW! Must be provided
	bucket_name                = "lacework-ct-bucket-8805c0bf"
	sns_topic_name             = "lacework-ct-sns-8805c0bf"
}

Refactor

  • refactor(aws): avoid using s3_bucket data source (Salim Afiune Maya)(ced2190)
  • refactor(aws): avoid using iam_role data source (Salim Afiune Maya)(c2a7a7f)

Bug Fixes

Documentation Updates

  • doc(aws): update aws/README.md (Salim Afiune Maya)(d15660f)

Other Changes

  • ci: update tests from modified examples/ (Salim Afiune Maya)(31e012d)

Signed-off-by: Salim Afiune Maya [email protected]

Signed-off-by: Salim Afiune Maya <[email protected]>
@afiune afiune requested a review from scottford-lw September 11, 2020 22:25
@afiune afiune self-assigned this Sep 11, 2020
Copy link
Contributor

@scottford-lw scottford-lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afiune afiune merged commit 09e7908 into master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants