Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: typecheck arrow objects before sending to Rust #914

Merged
merged 1 commit into from
May 30, 2023
Merged

feat: typecheck arrow objects before sending to Rust #914

merged 1 commit into from
May 30, 2023

Conversation

wjones127
Copy link
Contributor

This avoids confusing errors like

AttributeError: 'XXX' object has no attribute '_export_to_c'

We can also address this upstream in apache/arrow-rs#4312

@wjones127 wjones127 requested a review from eddyxu May 30, 2023 17:36
eddyxu
eddyxu approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Lgtm. pending CI.

@wjones127 wjones127 force-pushed the wjones127/typecheck-arrow branch from fa659ef to 496fc24 Compare May 30, 2023 18:30
@wjones127 wjones127 merged commit ae11934 into main May 30, 2023
@wjones127 wjones127 deleted the wjones127/typecheck-arrow branch May 30, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyxu eddyxu eddyxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjones127 @eddyxu