Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Precognition #8261

Merged
merged 86 commits into from
May 23, 2023
Merged

[10.x] Precognition #8261

merged 86 commits into from
May 23, 2023

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Sep 29, 2022

@timacdonald timacdonald marked this pull request as ready for review October 4, 2022 12:06
precognition.md Outdated Show resolved Hide resolved
@phh
Copy link

phh commented Oct 11, 2022

@timacdonald This looks awesome! We hope to adopt this as soon as possible! Any plans to when to release the npm packages - or if you would make the repositories public while they're getting worked on? 🙏

@mreduar
Copy link

mreduar commented Oct 12, 2022

@timacdonald This looks awesome! We hope to adopt this as soon as possible! Any plans to when to release the npm packages - or if you would make the repositories public while they're getting worked on? 🙏

I would also love to try it, I have been following the PR's since Laracon 😅

precognition.md Outdated Show resolved Hide resolved
precognition.md Outdated Show resolved Hide resolved
precognition.md Outdated Show resolved Hide resolved
precognition.md Outdated Show resolved Hide resolved
precognition.md Outdated Show resolved Hide resolved
precognition.md Outdated Show resolved Hide resolved
precognition.md Outdated Show resolved Hide resolved
@jiexaspb
Copy link

Hello,

npm install laravel-precognition-vue

this package is not found

@StubyProjects
Copy link

Hey, pretty cool feature so far. One question. How do I validate nested fields in an array. E.g calling form.validate('array.0.email') with inertia is not validated currently.

@panda-madness
Copy link

Awesome work guys! Any idea when the docs are going to get merged? Or do you want to finish up the JS packages before that?

@ahamilton9
Copy link

Any idea what happened? It looks like the backend code got merged into v9, but the docs and JS packages were incomplete. v10 just launched the other day. The Vue npm package points to github.com/laravel/precognition which doesn't seem to exist.

@ghost
Copy link

ghost commented Mar 1, 2023

Any idea what happened? It looks like the backend code got merged into v9, but the docs and JS packages were incomplete. v10 just launched the other day. The Vue npm package points to github.com/laravel/precognition which doesn't seem to exist.

I was using Precognition in one of my projects.
Sadly got the following error when I was building my app with SSR.

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '..\node_modules\laravel-precognition-vue\dist\inertia' imported from ..\node_modules\laravel-precognition-vue\dist\index.js

Found out after that thelaravel-precognition and laravel-precognition-vue are gone. Not to sure what happened with it, probably got set to private. Hope it gets added soon again, it's an amazing feature.

@timacdonald Any insights on where it went and when we can expect it to "release" again?

@nwehrhan
Copy link
Contributor

I was following precognition for awhile? Anyone know the state it's in?

@mreduar
Copy link

mreduar commented Mar 13, 2023

I was following precognition for awhile? Anyone know the state it's in?

I have installed it and tested it by doing a hack or two, but it works. But I still notice that it lacks features.

@nwehrhan
Copy link
Contributor

@mreduar What features is it lacking?

@mreduar
Copy link

mreduar commented Mar 13, 2023

@mreduar What features is it lacking?

One of them is to be able to validate more than one input at the same time, for now I could not get documentation nor seeing the code how to validate more than one input. I understand that it is intended only for use with @change, but it could be even more useful to validate more than one input.

@driesvints driesvints closed this Apr 7, 2023
@driesvints driesvints reopened this Apr 7, 2023
@driesvints driesvints changed the base branch from 9.x to 10.x April 7, 2023 07:43
@driesvints driesvints changed the title [9.x] Precognition [10.x] Precognition Apr 7, 2023
@driesvints
Copy link
Member

@timacdonald should this PR be reconsidered?

@timacdonald
Copy link
Member Author

@driesvints we are discussing it internally at the moment.

@laserhybiz
Copy link
Contributor

any updates?

10.x Outdated Show resolved Hide resolved
@taylorotwell taylorotwell marked this pull request as ready for review May 10, 2023 17:53
@taylorotwell taylorotwell marked this pull request as draft May 10, 2023 18:43
@taylorotwell taylorotwell marked this pull request as ready for review May 23, 2023 02:04
@taylorotwell taylorotwell merged commit f9089ad into laravel:10.x May 23, 2023
@timacdonald timacdonald deleted the precognition branch May 23, 2023 02:41
@timacdonald
Copy link
Member Author

"For the record, we never broke up; we just took a fourteen-year vacation".

@laserhybiz
Copy link
Contributor

@timacdonald any chance the frontend packages repo will be made public?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.