[9.x] Check if isPrecognitive() method exists before calling it #44565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ValidatesWhenResolvedTrait calls a method that is only present in the CanBePrecognitive trait. Check that the isPrecognitive() method exists before calling it.
|
@ejunker Not sure why you closed this. It is still happening ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ValidatesWhenResolvedTraitcallsisPrecognitive()which is only present in theCanBePrecognitivetrait. TheCanBePrecognitivetrait is used inRequest. This works fine withFormRequestbecause it extendsRequestbut if you want to use theValidatesWhenResolvedTraitto create your own validating objects it has an error. This change will check if theisPrecognitive()method exists before calling it.I am using the
ValidatesWhenResolvedTraitin my DTOs so that when it is resolved it can also validate the data.