[7.x] Fix ChromeDriverCommand for ChromeDriver 115+ #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
commented
Jul 22, 2023
| * | ||
| * @var string | ||
| */ | ||
| protected $downloadUrl = 'https://chromedriver.storage.googleapis.com/%s/chromedriver_%s.zip'; |
There was a problem hiding this comment.
URLs will be hardcoded based on usage to support different version.
crynobone
commented
Jul 22, 2023
| 'mac-intel' => 'mac64', | ||
| 'mac-arm' => 'mac_arm64', | ||
| 'win' => 'win32', | ||
| ]; |
There was a problem hiding this comment.
Moved to OperatingSystem, use OperatingSystem::chromeDriverSlug($os).
crynobone
commented
Jul 22, 2023
| 'win' => [ | ||
| 'reg query "HKEY_CURRENT_USER\Software\Google\Chrome\BLBeacon" /v version', | ||
| ], | ||
| ]; |
There was a problem hiding this comment.
Moved to OperatingSystem, use OperatingSystem::chromeVersionCommands($os).
crynobone
commented
Jul 22, 2023
| 'slug' => 'mac-arm64', | ||
| 'commands' => [ | ||
| '/Applications/Google\ Chrome\ for\ Testing.app/Contents/MacOS/Google\ Chrome\ for\ Testing --version', | ||
| '/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --version', |
There was a problem hiding this comment.
Add support for Chrome for Testing.app, available from version 113: https://googlechromelabs.github.io/chrome-for-testing/latest-versions-per-milestone-with-downloads.json
Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
commented
Jul 22, 2023
| 'sink' => $resource, | ||
| ]), array_filter([ | ||
| 'proxy' => $this->option('proxy'), | ||
| ]))->get($url); |
There was a problem hiding this comment.
Use Laravel HTTP Client to speed up downloading ChromeDriver 115.
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
commented
Jul 22, 2023
| @@ -13,10 +13,11 @@ | |||
| "php": "^8.0", | |||
| "ext-json": "*", | |||
| "ext-zip": "*", | |||
| "php-webdriver/webdriver": "^1.9.0", | |||
| "nesbot/carbon": "^2.0", | |||
| "guzzlehttp/guzzle": "^7.2", | |||
There was a problem hiding this comment.
Allows to use HTTP Client.
Kayrah87
pushed a commit
to Kayrah87/legacy-dusk
that referenced
this pull request
Jul 28, 2023
* [7.x] Fix ChromeDriverCommand for ChromeDriver 115+ Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * Update OperatingSystemTest.php * Update ChromeDriverCommand.php * formatting * formatting --------- Signed-off-by: Mior Muhammad Zaki <[email protected]> Co-authored-by: Taylor Otwell <[email protected]>
demondehellis
pushed a commit
to SwiftregUK/dusk
that referenced
this pull request
Sep 8, 2023
* [7.x] Fix ChromeDriverCommand for ChromeDriver 115+ Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * Update OperatingSystemTest.php * Update ChromeDriverCommand.php * formatting * formatting --------- Signed-off-by: Mior Muhammad Zaki <[email protected]> Co-authored-by: Taylor Otwell <[email protected]>
demondehellis
pushed a commit
to SwiftregUK/dusk
that referenced
this pull request
Sep 8, 2023
--------- Signed-off-by: Mior Muhammad Zaki <[email protected]> Co-authored-by: Taylor Otwell <[email protected]>
demondehellis
pushed a commit
to SwiftregUK/dusk
that referenced
this pull request
Sep 8, 2023
--------- Signed-off-by: Mior Muhammad Zaki <[email protected]> Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1040