[7.x] Prevent interaction with Http::preventStrayRequests
#1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of the
Httpfacade with direct use of the Guzzle client allowing the request to be made regardless of stray requests being prevented.Since #1043 the
getUrlmethod for thedusk:chrome-drivercommand has used theHttpfacade to get the URL for the latest download URL. This has the unintended consequence of throwing an exception if stray requests are being prevented. Previously the URL was obtained usingfile_get_contentsso it would still allow the command to successfully execute when requests are being prevented.The Guzzle client is also directly used in the
downloadmethod already.