-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.x] Add support for arm64 macOS #869
Conversation
@sirdharma perfect, thanks! |
Fail
Fail |
@driesvints Thanks for that. I'll confirm the behavior as soon as I have access to an Intel Mac. |
@driesvints I had all sorts of trouble installing an Intel version of Google Chrome, because of the way it enforces auto-updates on the user 🥲. I've also had my teammates (Intel Mac and Linux) try the branch and confirm that Dusk correctly installs the appropriate Please let me know what you think. Thanks! |
@sirdharma thanks for this. I'm going to put this one in draft for a bit longer until we've first merged #873 After that I'm going to have to ask you to rebase this PR with master. |
@sirdharma that PR is merged now. Can you rebase this one? |
74c1117
to
fbc6dd3
Compare
@driesvints Done. |
Perfect. Thanks @sirdharma! |
This is a first pass at adding support for
arm64
macOS.I am opening this PR in order to start the discussion, alongside with the issue I opened earlier: #868.
On top of my head, this may raise a couple issues (but there may be more):
arm64_m1
version of ChromeDriver is not available for the targeted Chrome version? Do we want to fail or fallback?arm64
version of ChromeDriver can start an Intel process.I have tested this locally and it seems to work fine. The benefit is huge: running our Dusk test suite went from 7m 23s down to 3m 51s on my 13-inch M1 MacBook Pro.
Thank you!