[7.x] Remove chrome binaries #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crynobone I think I need to reverse PHPUnit v10 support on Dusk since Testbench doesn't yet supports it? |
driesvints
force-pushed
the
remove-chrome-binaries
branch
from
1f6f006 to
5239e3c
Compare
driesvints
force-pushed
the
remove-chrome-binaries
branch
from
5239e3c to
d6d545f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove shipped chrome binaries. This is because of a couple of reasons:
The current
dusk:installcommand already installs the correct Chrome version. I've also modified this to only install the OS specific one by default. Installing binaries which can't be run anyway doesn't really makes sense. The option remains on thedusk:chrome-drivercommand if people really need it.This PR also fixes quite a few tests. I noticed at some point I was getting weird Mockery exception failures after introducing Testbench. Turns out none of the existing tests had the
m::closein place. I added these and fixed all existing tests with the proper expectations.