Skip to content

Commit

Permalink
Revert "[5.8] WithFaker use local faker config"
Browse files Browse the repository at this point in the history
  • Loading branch information
GrahamCampbell authored Jul 21, 2019
1 parent 5140a0b commit f1a7255
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Illuminate/Foundation/Testing/WithFaker.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@ protected function faker($locale = null)
*/
protected function makeFaker($locale = null)
{
return Factory::create($locale ?? config('app.faker_locale') ?? Factory::DEFAULT_LOCALE);
return Factory::create($locale ?? Factory::DEFAULT_LOCALE);
}
}

2 comments on commit f1a7255

@stephanecoinon
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GrahamCampbell , why revert this PR? This would be very handy outside the US

@devcircus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.