New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] WithFaker use local faker config #29123

Merged

taylorotwell merged 1 commit into laravel:5.8 from cxlblm:5.8

Jul 10, 2019

Contributor

cxlblm commented Jul 10, 2019

WithFaker use local faker config


          WithFaker use local faker config

d46bc25

WithFaker use local faker config

GrahamCampbell changed the title ~~WithFaker use local faker config~~ [5.8] WithFaker use local faker config

taylorotwell merged commit fccb701 into laravel:5.8

Member

GrahamCampbell commented Jul 21, 2019

This was actually already added to Laravel 5.9 in #28478, because it was a breaking change. I think we should revert this PR to 5.8.

GrahamCampbell mentioned this pull request

[5.8] Revert "[5.8] WithFaker use local faker config" #29250

Merged

devcircus referenced this pull request


          Revert "[5.8] WithFaker use local faker config"

f1a7255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet