-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support windows binary build #45
feat: support windows binary build #45
Conversation
"actions":[ | ||
{ | ||
"outputs": [ | ||
"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this outputs
field contains an empty string.
because empty content in outputs
will let node-gyp skip the actions.
so it's a workaround keeping actions works.
Thanks for the PR! Will review ASAP to get this merged! |
hey can somebody with a windows machine verify this? Or @aquariuslt can you send me a telegram message so we can meet and verify this together (pyramation) is my telegram |
once this is merged, we should see how to get it working in the github workflow to get the full automation going: https://github.com/launchql/libpg-query-node/blob/16-latest/.github/workflows/npm-publish.yml |
@pyramation thanks for the ping! Did you meet with @aquariuslt to verify this? If not, @aquariuslt what are the steps that someone with a Windows machine could follow to test out this PR? CCs
|
sorry for late reply. i will contact @pyramation today.
|
hi pyramtion, my telegram is |
Hi @aquariuslt, I followed your 3 steps for testing out the PR
the build process ran without an error on my side, please find the package attached |
Here is my console output:
|
awesome! thanks everyone — chatting with @aquariuslt in telegram to get this streamlined! |
published! thank you @aquariuslt :) |
@pyramation I can happily confirm that everything looks okay so far |
yay! thanks @Davidihl :) |
@pyramation I set up a simple workflow just today on GitHub Actions, which installs Relevant parts of the workflow: name: CI
on: push
jobs:
ci:
name: CI
runs-on: windows-latest
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v3
with:
version: 'latest'
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 'lts/*'
cache: 'pnpm'
- name: Install dependencies
run: pnpm install I ran this just now (runner:
|
feature: support windows build
related Issues #44 #22
file changes
nmake
build command, and copy builtpg_query.lib
pg_query.h
to including lib dirscript/buildAddons.bat
references
binding.gyp build options/compile options related link
1.1. https://github.com/pganalyze/libpg_query?tab=readme-ov-file#installation
1.2. Overriding default flags nodejs/node-gyp#26 (comment)
nmake
requiredVisual Studio Developer Command Prompt
in the path env.which means users should run install script at
Visual Studio Developer Command Prompt
at the first time.below is my local build log
gyp build log
pg_query windows build log