Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support windows binary build #45

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 40 additions & 12 deletions binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@
"src/sync.cc",
"src/async.cc"
],
"actions": [
{
"outputs": ['libpg_query/include/pg_query.h'],
"inputs": [],
"action": ['script/buildAddon.sh'],
"action_name": 'prebuild_dependencies'
}
],
'cflags!': [ '-fno-exceptions' ],
'cflags_cc!': [ '-fno-exceptions' ],
'include_dirs': [
Expand All @@ -25,22 +17,58 @@
'dependencies': ["<!(node -p \"require('node-addon-api').gyp\")"],
'conditions': [
['OS=="linux"', {
"libraries": [ "-L<!(pwd)/libpg_query/linux", "-lpg_query" ]
"libraries": [ "-L<!(pwd)/libpg_query/linux", "-lpg_query" ],
"actions": [
{
"outputs": ['libpg_query/include/pg_query.h'],
"inputs": [],
"action": ['script/buildAddon.sh'],
"action_name": 'prebuild_dependencies'
}
],
}],
['OS=="mac"', {
"libraries": [ "-L<!(pwd)/libpg_query/osx", "-lpg_query" ],
"xcode_settings": {
"CLANG_CXX_LIBRARY": "libc++",
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
'MACOSX_DEPLOYMENT_TARGET': '10.7'
}
},
"actions": [
{
"outputs": ['libpg_query/include/pg_query.h'],
"inputs": [],
"action": ['script/buildAddon.sh'],
"action_name": 'prebuild_dependencies'
}
],
}],
['OS=="win"', {
"link_settings": {
"library_dirs": [
"../libpg_query/windows"
],
"libraries": [
"../libpg_query/windows/pg_query.lib"
],
},
"msvs_settings": {
"VCCLCompilerTool": {
"ExceptionHandling": 1
"ExceptionHandling": 0,
"AdditionalOptions": ["/EHsc"]
}
},
"defines": [ "NAPI_DISABLE_CPP_EXCEPTIONS" ],
"actions":[
{
"outputs": [
""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this outputs field contains an empty string.
because empty content in outputs will let node-gyp skip the actions.

so it's a workaround keeping actions works.

],
"inputs": [],
"action": ['../script/buildAddon.bat'],
"action_name": 'prebuild_dependencies'
}
}
]
}]
]
}
Expand Down
68 changes: 68 additions & 0 deletions script/buildAddon.bat
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
@echo off

set commit=1ec38940e5c6f09a4c1d17a46d839a881c4f2db7
set branch=16-latest

setlocal enabledelayedexpansion

rem Remember current's parent directory and create a new, unique, temporary directory
set buildDir=%cd%
set projectDir=%cd%\..
set tmpDir=%temp%\tmpdir.libpg_query
rmdir /s /q %tmpDir%
md %tmpDir%


rem Define the make target
set makeTarget=build

rem Change to the newly created temp directory
cd /D %tmpDir%


rem Clone the selected branch of the libpg_query Git repo
git clone -b %branch% --single-branch https://github.com/pganalyze/libpg_query.git
cd libpg_query

rem Checkout the desired commit
git checkout %commit%

rem needed if being invoked from within gyp
set MAKEFLAGS=
set MFLAGS=

rem set path with Windows Developer Command Prompt
echo "please ensure you are running at Windows Developer Command Prompt environments"
nmake /F Makefile.msvc clean
nmake /F Makefile.msvc build


rem Terminate if build fails
if %errorlevel% NEQ 0 (
echo ERROR: 'nmake' command failed
)

rem Search for pg_query.obj (libpg_query.a), error if not found
for /f "delims=" %%f in ('dir /b /s pg_query.lib') do set file=%%f
if not defined file (
echo "ERROR: pg_query.lib not found"

)

rem Error if pg_query.h is missing
for /f "delims=" %%f in ('dir /b /s pg_query.h') do set file=%%f
if not defined file (
echo "ERROR: pg_query.h not found"

)

rem Copy pg_query.lib to windows dir
copy /Y pg_query.lib "%projectDir%\libpg_query\windows\"

rem Copy header
copy /Y pg_query.h "%projectDir%\libpg_query\include\"

rem Cleanup: revert to original directory
cd /D %buildDir%

exit /B 0