-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cell.target_size #6
Comments
@lavinrp I've been messing with this one and I think I almost have it in a good state. It can get a little messy but I think that's still because of #27. Also, should |
@zackelia Lets add target_size in addition to max_radius. Recommended Implementation:Currently max_radius is responsible for the size that a cell grows to (via the PassiveGrowth cell event). Lets give target_size that responsibility (and let it grow or shrink the cell). For now lets let max_radius win if the target_size is greater than max_radius. This feel like it may get messy that way. If so we can look at simplifying. Notes:
Feature RequirementsAt the end of the day we want:
|
Sorry for the long delay, I've been able to start working on this again. I've added some comments to my commit if you would look them over (also is this the best way to do this or should I just initiate a code review and comment?) |
@zackelia If you think something is ready to merge best thing to do is make a pull request. If something still needs work but you want early feedback you can make a "draft pull request" In both scenarios just assign me as a reviewer and I'll take a look as soon as I can. Throwing an @lavinrp in the issue or in the pull request never hurts though. |
cells should slowly grow or shrink to fit their target size.
This variable can be set by furrow events to cause cells to automatically change their size over time.
The text was updated successfully, but these errors were encountered: