Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding by percent not mapped #186

Closed
ghost opened this issue Sep 8, 2021 · 0 comments
Closed

Padding by percent not mapped #186

ghost opened this issue Sep 8, 2021 · 0 comments

Comments

@ghost
Copy link

ghost commented Sep 8, 2021

Yoga supports paddings by percent, but is not mapped in FlexLayout.

In margins for example is supported:

    @discardableResult
    public func margin(_ percent: FPercent) -> Flex {
        yoga.margin = YGValue(value: Float(percent.value), unit: .percent)
        return self
    }

The idea is do the same applied to paddings, for example:

   @discardableResult
    public func padding(_ percent: FPercent) -> Flex {
        yoga.padding = YGValue(value: Float(percent.value), unit: .percent)
        return self
    }
ghost pushed a commit to nomasystems/FlexLayout that referenced this issue Sep 10, 2021
ghost pushed a commit to nomasystems/FlexLayout that referenced this issue Sep 10, 2021
ghost pushed a commit to nomasystems/FlexLayout that referenced this issue Nov 22, 2021
ghost pushed a commit to nomasystems/FlexLayout that referenced this issue Nov 22, 2021
ghost pushed a commit to nomasystems/FlexLayout that referenced this issue Nov 22, 2021
ghost pushed a commit to nomasystems/FlexLayout that referenced this issue Nov 22, 2021
ghost pushed a commit to nomasystems/FlexLayout that referenced this issue Nov 22, 2021
lucdion added a commit that referenced this issue Nov 22, 2021
@ghost ghost closed this as completed Nov 30, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants