Percent padding support. Solves #186 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, we're using this feature in apps with millions of users, any chance of being reviewed? Thanks! |
|
Sorry @albertocsouto, I have missed that PR |
lucdion
requested changes
Nov 16, 2021
|
Also, please update your work branch with the latest |
ghost
force-pushed
the
feat/186-percent-padding
branch
3 times, most recently
from
c6c1566 to
bf8394b
Compare
Applied suggested changes, thanks for your patience :) |
|
Last thing @albertocs-noma , could you update your branch with recent changes from the main branch? To fix that:
|
ghost
force-pushed
the
feat/186-percent-padding
branch
from
bf8394b to
94c8458
Compare
ghost
force-pushed
the
feat/186-percent-padding
branch
from
94c8458 to
cf5e2f7
Compare
Should be solved, sorry for the inconvenience! |
|
Release created https://github.com/layoutBox/FlexLayout/releases/tag/1.3.23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Padding by percent added in the same fashion as margins. Solves #186