Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restart configuration for services #38

Merged
merged 1 commit into from
May 5, 2024
Merged

Fix restart configuration for services #38

merged 1 commit into from
May 5, 2024

Conversation

piemonkey
Copy link
Contributor

Overview

I noticed these were wrong when testing a PR.

connected issues and PRs:

N/A

Setup

N/A

How to test/reproduce

Start the stack (prod config), restart the docker daemon (or your machine), see that the services start.
Then do the same with the dev config and see that they do not.

Challenges/uncertainties

I added the secure cookies config a while ago. I can't remember what problem it was to solve, but since it's on the dev config and it's on GN, I figured I might as well add it...

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@piemonkey piemonkey requested review from dkozickis and abeforgit May 3, 2024 19:00
@abeforgit abeforgit merged commit 52aaa13 into master May 5, 2024
@abeforgit abeforgit deleted the fix/restarts branch May 5, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants