Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support notulen being files #123

Merged
merged 5 commits into from
May 5, 2024
Merged

Conversation

abeforgit
Copy link
Member

@abeforgit abeforgit commented Apr 26, 2024


Overview

As the besluit-publicatie service is actually parsing the notulen and re-inserting the html,
but enhanced with some extra rdfa, we needed to also store that version as a file, and make
this frontend compatible with that

connected issues and PRs:

lblod/besluit-publicatie-publish-service#13
https://binnenland.atlassian.net/browse/GN-4775
lblod/app-gn-publicatie#37

Setup

How to test/reproduce

Challenges/uncertainties

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@abeforgit abeforgit merged commit 2245ddd into master May 5, 2024
1 of 3 checks passed
@abeforgit abeforgit deleted the feat/publication-as-files branch May 5, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants