Support the publication of large meeting notulen #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While we already have publications coming in as files from GN, the publish service was still
enhancing the html and storing that as a db string, generating the same problems as before.
Additionally, that service was very very inefficient, and crashing seemingly at random for
large publications. I suspect it was simply hitting some kind of resource limits, but I can't
be sure.
In any case, the publish service has been greatly optimized in the linked PR and the frontend
has been updated to accommodate the file storage.
On the app config itself, I added the file config to the resources config to support the changes in the frontend.
connected issues and PRs:
JIRA: https://binnenland.atlassian.net/browse/GN-4775
service: lblod/besluit-publicatie-publish-service#13
frontend: lblod/frontend-gelinkt-notuleren-publicatie#123
Setup
This app has always assumed it runs on the same machine as Gelinkt Notuleren and required
a volume mount for the GN files (this was initially done for attachments, but is now also used
for the publications).
This kind of setup is also used in production.
(for both of the below configs: merge with what you already have, dont completely overwrite your override file)
app-gelinkt-notuleren-publicatie: docker-compose.override
app-gelinkt-notulereln: docker-compose.override
How to test/reproduce
Challenges/uncertainties
Checks PR readiness