[Merged by Bors] - feat: port Algebra.Group.Units #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pechersky
added
help-wanted
mathlib hash: 7cca171008afb30576d2d4c51173700a780c23d0
…rt-algebra-group-units
pechersky
added
blocked-by-other-PR
…rt-algebra-group-units
With some remaining naming convention docstring edits
j-loreaux
removed
the
blocked-by-other-PR
kim-em
added
awaiting-author
Needed one workaround for a simp proof
pechersky
added
awaiting-review
and removed
awaiting-author
kim-em
reviewed
Nov 23, 2022
kim-em
reviewed
Nov 23, 2022
kim-em
reviewed
Nov 23, 2022
| theorem mul_inv_eq_iff_eq_mul {a c : α} : a * ↑b⁻¹ = c ↔ a = c * b := | ||
| ⟨fun h => by rw [← h, inv_mul_cancel_right], fun h => by rw [h, mul_inv_cancel_right]⟩ | ||
|
|
||
| -- Porting note: have to explicitly type annotate the 1 |
There was a problem hiding this comment.
Maybe no longer true? Also below.
There was a problem hiding this comment.
Still true, otherwise:
failed to synthesize instance
HMul ℕ αˣ α
kim-em
reviewed
Nov 23, 2022
|
bors d+ |
|
✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
mathlib hash: 7cca171008afb30576d2d4c51173700a780c23d0 - [x] depends on: #600 Co-authored-by: Mario Carneiro <[email protected]> Co-authored-by: Ruben Van de Velde <[email protected]> Co-authored-by: Scott Morrison <[email protected]> Co-authored-by: Yakov Pechersky <[email protected]> Co-authored-by: Jireh Loreaux <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 24, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.char_zero.defs`: leanprover-community/mathlib4#661 * `algebra.group.inj_surj`: leanprover-community/mathlib4#707 * `algebra.group.order_synonym`: leanprover-community/mathlib4#651 * `algebra.group.units`: leanprover-community/mathlib4#549 * `algebra.hierarchy_design`: leanprover-community/mathlib4#657 * `algebra.quotient`: leanprover-community/mathlib4#643 * `algebra.ring.defs`: leanprover-community/mathlib4#655 * `algebra.ring.order_synonym`: leanprover-community/mathlib4#671 * `control.equiv_functor`: leanprover-community/mathlib4#649 * `data.dlist.basic`: leanprover-community/mathlib4#616 * `data.int.cast.basic`: leanprover-community/mathlib4#670 * `data.lazy_list`: leanprover-community/mathlib4#686 * `data.list.lex`: leanprover-community/mathlib4#672 * `data.option.n_ary`: leanprover-community/mathlib4#656 * `data.sigma.lex`: leanprover-community/mathlib4#646 * `data.ulift`: leanprover-community/mathlib4#703 * `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626 * `logic.equiv.basic`: leanprover-community/mathlib4#631 * `order.iterate`: leanprover-community/mathlib4#648
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 25, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.char_zero.defs`: leanprover-community/mathlib4#661 * `algebra.group.inj_surj`: leanprover-community/mathlib4#707 * `algebra.group.order_synonym`: leanprover-community/mathlib4#651 * `algebra.group.units`: leanprover-community/mathlib4#549 * `algebra.hierarchy_design`: leanprover-community/mathlib4#657 * `algebra.opposites`: leanprover-community/mathlib4#644 * `algebra.quotient`: leanprover-community/mathlib4#643 * `algebra.ring.defs`: leanprover-community/mathlib4#655 * `algebra.ring.order_synonym`: leanprover-community/mathlib4#671 * `control.equiv_functor`: leanprover-community/mathlib4#649 * `data.dlist.basic`: leanprover-community/mathlib4#616 * `data.int.cast.basic`: leanprover-community/mathlib4#670 * `data.lazy_list`: leanprover-community/mathlib4#686 * `data.list.lex`: leanprover-community/mathlib4#672 * `data.option.n_ary`: leanprover-community/mathlib4#656 * `data.sigma.lex`: leanprover-community/mathlib4#646 * `data.ulift`: leanprover-community/mathlib4#703 * `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626 * `logic.equiv.basic`: leanprover-community/mathlib4#631 * `order.iterate`: leanprover-community/mathlib4#648
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Feb 14, 2023
Missing `to_additive` I had actually added this to mathlib4 3 months ago in leanprover-community/mathlib4@cbc0834 (leanprover-community/mathlib4#549), and never noticed it wasn't in mathlib3. mathlib4 hash-update placeholder pr: leanprover-community/mathlib4#2278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mathlib hash: 7cca171008afb30576d2d4c51173700a780c23d0
nontrivialitytactic #600