Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Control.Applicative #798

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Control.Applicative #798

wants to merge 5 commits into from

Conversation

zeramorphic
Copy link
Collaborator

mathlib3 SHA: 4e42a9d0a79d151ee359c270e498b1a00cc6fa4e

A couple of changes needed to be made because Seq.seq now has a Unit argument. There remain some sorries that were previously solved by control_laws_tac.

@zeramorphic
Copy from mathport
9bf64ca 
Signed-off-by: thirdsgames <[email protected]>
@zeramorphic
Fix errors
5494fed 
Signed-off-by: thirdsgames <[email protected]>
@zeramorphic
Remove extraneous skip
8decdc1 
Signed-off-by: thirdsgames <[email protected]>
@zeramorphic zeramorphic added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Nov 30, 2022
@zeramorphic
Add to Mathlib.lean
a1b1079 
Signed-off-by: thirdsgames <[email protected]>
@zeramorphic
Solve final sorries
c40b078 
Signed-off-by: thirdsgames <[email protected]>
@zeramorphic zeramorphic added awaiting-review and removed WIP Work in progress labels Nov 30, 2022
@zeramorphic zeramorphic marked this pull request as ready for review November 30, 2022 14:08
@kim-em
Copy link
Contributor

kim-em commented Nov 30, 2022

Thanks for the thorough porting notes. I think I am going to merge as is, rather than devoting more effort to diagnosing underlying causes of the changes here, as the Control directory is lower-priority for the porting effort overall. Having the good porting notes means we can return to this later.

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Nov 30, 2022
bors bot pushed a commit that referenced this pull request Nov 30, 2022
@zeramorphic
feat: port Control.Applicative (#798)
c8e9a35 
mathlib3 SHA: 4e42a9d0a79d151ee359c270e498b1a00cc6fa4e

A couple of changes needed to be made because `Seq.seq` now has a `Unit` argument. There remain some sorries that were previously solved by `control_laws_tac`.
@bors
Copy link

bors bot commented Nov 30, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Control.Applicative [Merged by Bors] - feat: port Control.Applicative Nov 30, 2022
@bors bors bot closed this Nov 30, 2022
@bors bors bot deleted the Control.Applicative branch November 30, 2022 17:19
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Closed
bors bot pushed a commit to leanprover-community/mathlib3 that referenced this pull request Dec 1, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17754)
8d89a80 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.field.defs`: leanprover-community/mathlib4#668
* `algebra.group.commute`: leanprover-community/mathlib4#750
* `algebra.group_with_zero.commute`: leanprover-community/mathlib4#762
* `algebra.group_with_zero.semiconj`: leanprover-community/mathlib4#757
* `algebra.group_with_zero.units.basic`: leanprover-community/mathlib4#735
* `algebra.hom.embedding`: leanprover-community/mathlib4#764
* `algebra.order.monoid.cancel.defs`: leanprover-community/mathlib4#774
* `algebra.order.monoid.canonical.defs`: leanprover-community/mathlib4#778
* `algebra.order.monoid.defs`: leanprover-community/mathlib4#771
* `algebra.order.monoid.min_max`: leanprover-community/mathlib4#763
* `algebra.order.monoid.order_dual`: leanprover-community/mathlib4#786
* `algebra.order.sub.defs`: leanprover-community/mathlib4#732
* `algebra.regular.basic`: leanprover-community/mathlib4#758
* `algebra.ring.commute`: leanprover-community/mathlib4#759
* `algebra.ring.regular`: leanprover-community/mathlib4#795
* `algebra.ring.semiconj`: leanprover-community/mathlib4#751
* `control.applicative`: leanprover-community/mathlib4#798
* `control.functor`: leanprover-community/mathlib4#612
* `control.monad.basic`: leanprover-community/mathlib4#752
* `data.countable.defs`: leanprover-community/mathlib4#736
* `data.int.units`: leanprover-community/mathlib4#807
* `data.nat.basic`: leanprover-community/mathlib4#729
* `data.nat.psub`: leanprover-community/mathlib4#806
* `data.nat.units`: leanprover-community/mathlib4#805
* `data.pi.algebra`: leanprover-community/mathlib4#564
* `data.prod.lex`: leanprover-community/mathlib4#783
* `logic.embedding.basic`: leanprover-community/mathlib4#700
* `logic.equiv.option`: leanprover-community/mathlib4#674
* `order.bounded_order`: leanprover-community/mathlib4#697
* `order.with_bot`: leanprover-community/mathlib4#776
* `order.disjoint`: leanprover-community/mathlib4#773
* `order.min_max`: leanprover-community/mathlib4#728
* `order.prop_instances`: leanprover-community/mathlib4#792
* `order.rel_iso.basic`: leanprover-community/mathlib4#772
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeramorphic @kim-em