-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button docs #165
Button docs #165
Conversation
0f2e263
to
473f865
Compare
This is great! Two follow-ups, I believe:
and I think it should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
473f865
to
0e55557
Compare
thanks for the feedback both. Ready for re-review. @nucleogenesis added a basic unit test for that filter, but I am not actually sure that github actions is actually running the test suite. Need to investigate |
0e55557
to
3489f7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good eye - @nucleogenesis ! Manually tested the issue that he brought up, and the filtering with "button" seems to work now. LGTM!
Co-authored-by: Jessica Aceret <[email protected]>
Component documentation
Adds documentation for library components:
KButton
KRouterLink
KExternalLink
KButtonGroup
KIconButton
Filter keywords
Adds a new 'keywords' property to the table of contents to allow filtering by related terms. For example:
Cross-links to components
Adds a new
DocsLibraryLink
component to allow easy cross-linking. For example: