EQM: Notify not enough resources to replace questions #12219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Build Artifacts
|
AlexVelezLl
force-pushed
the
notify-not-enough-replacements
branch
from
d9ff9d8 to
7bb7603
Compare
AlexVelezLl
commented
May 29, 2024
| @@ -117,19 +117,17 @@ export default function useQuizCreation() { | |||
| }, | |||
| [] | |||
| ); | |||
| if (removedResourceQuestionIds.length === 0) { | |||
| // If no resources were removed, we don't need to update the questions | |||
| return; | |||
There was a problem hiding this comment.
This return here has making the whole function to return, and the updates werent applied when we had resource_pool updates.
nucleogenesis
requested changes
May 30, 2024
| v-if="showNoEnoughResources" | ||
| :selectedQuestions="selectedActiveQuestions" | ||
| :availableResources="replacementQuestionPool" | ||
| @close="showNoEnoughResources = false" |
There was a problem hiding this comment.
This should also "go back" in the router and close the side panel.
|
Thank you @nucleogenesis! I have updated the close handler! |
|
Hi @AlexVelezLl I confirm that this is implemented as specified in #12094 but while testing I noticed the following:
2024-05-31_11-34-39.mp4 |
nucleogenesis
approved these changes
May 31, 2024
Comment on lines
+125
to
+131
| <NotEnoughResourcesModal | ||
| v-if="showNoEnoughResources" | ||
| :selectedQuestions="selectedActiveQuestions" | ||
| :availableResources="replacementQuestionPool" | ||
| @close="closeNoEnoughResourcesModal" | ||
| @addResources="redirectToSelectResources" | ||
| /> |
There was a problem hiding this comment.
To @pcenov 's comment about the side panel showing under the modal, I think maybe moving this to the CreateQuizSection component would help. Show the modal before navigating there and should be good to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a modal to notify the user when there are no enough resources to replace the current selected questions
Compartir.pantalla.-.2024-05-28.16_43_28.mp4
References
Closes #12094
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarnandpip)