-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trancate text #9868
trancate text #9868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AllanOXDi - thanks for working on this! I added a question and a small fix request to remove the volta reference from your package.json
.
@@ -45,7 +45,7 @@ | |||
<h3 class="title" dir="auto"> | |||
<TextTruncatorCss | |||
:text="content.title" | |||
:maxLines="3" | |||
:maxLines="1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary for this just to be "1"? When we had looked at it together, it seemed like having the max lines set to 2 would be acceptable and not cause a conflict. I'm worried that having only one line might result in not enough text being displayed for some longer titles. If you have a screenshot of an example that demonstrates why "1" is better, that would be helpful to include in the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Marcella! I have tried setting it to 2. But I realised that setting it to one is actually better.
screen-capture (3).webm
Please don't merge it yet today as I explore more alternatives.
Thanks for updating the |
Summary
This fixes content card layout overlaps to reduce layout conflicts.
References
screen-capture.3.webm.mp4
closes #9842
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)