Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trancate text #9868

Merged
merged 2 commits into from
Dec 8, 2022
Merged

trancate text #9868

merged 2 commits into from
Dec 8, 2022

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Nov 24, 2022

Summary

This fixes content card layout overlaps to reduce layout conflicts.

References

screen-capture.3.webm.mp4

closes #9842

Reviewer guidance

  • Ensure you have the "Kolibri QA Channel" imported
  • Open up "Make 10, grids and number bonds"
  • Shrink the browser window enough that the cards become narrower and observe.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AllanOXDi - thanks for working on this! I added a question and a small fix request to remove the volta reference from your package.json.

@@ -45,7 +45,7 @@
<h3 class="title" dir="auto">
<TextTruncatorCss
:text="content.title"
:maxLines="3"
:maxLines="1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary for this just to be "1"? When we had looked at it together, it seemed like having the max lines set to 2 would be acceptable and not cause a conflict. I'm worried that having only one line might result in not enough text being displayed for some longer titles. If you have a screenshot of an example that demonstrates why "1" is better, that would be helpful to include in the PR!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marcella! I have tried setting it to 2. But I realised that setting it to one is actually better.
screen-capture (3).webm

Please don't merge it yet today as I explore more alternatives.

@marcellamaki
Copy link
Member

Thanks for updating the package.json @AllanOXDi - I'll go ahead and merge this, and if we come to more ideas about spacing in the future, or with design input, we can update it.

@marcellamaki marcellamaki merged commit 92260a6 into learningequality:release-v0.15.x Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants