Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trancate text #9868

Merged
merged 2 commits into from
Dec 8, 2022
Merged

trancate text #9868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a26c1d8
trancate text
AllanOXDi Nov 24, 2022
18435f4
removed the volta referencefrom the package.json
AllanOXDi Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kolibri/plugins/learn/assets/src/views/HybridLearningContentCard/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<h3 class="title" dir="auto">
<TextTruncatorCss
:text="content.title"
:maxLines="3"
:maxLines="1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary for this just to be "1"? When we had looked at it together, it seemed like having the max lines set to 2 would be acceptable and not cause a conflict. I'm worried that having only one line might result in not enough text being displayed for some longer titles. If you have a screenshot of an example that demonstrates why "1" is better, that would be helpful to include in the PR!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marcella! I have tried setting it to 2. But I realised that setting it to one is actually better.
screen-capture (3).webm

Please don't merge it yet today as I explore more alternatives.

/>
</h3>
<KButton
Expand Down
2 changes: 1 addition & 1 deletion kolibri/plugins/learn/assets/src/views/cards/BaseCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<TextTruncatorCss
dir="auto"
:text="title"
:maxLines="2"
:maxLines="1"
/>
</h3>
</div>
Expand Down