-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit modal - add additional fields to "Basic info" section #3370
Edit modal - add additional fields to "Basic info" section #3370
Conversation
5b35db1
to
13b58ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things that could be tweaked, but nothing alarming. I have not yet manually tested.
contentcuration/contentcuration/frontend/channelEdit/components/edit/ResourcesNeededOptions.vue
Outdated
Show resolved
Hide resolved
...ntentcuration/frontend/channelEdit/components/edit/__tests__/learningActivityOptions.spec.js
Show resolved
Hide resolved
...uration/contentcuration/frontend/channelEdit/components/edit/__tests__/levelsOptions.spec.js
Show resolved
Hide resolved
...ontentcuration/frontend/channelEdit/components/edit/__tests__/resourcesNeededOptions.spec.js
Show resolved
Hide resolved
13b58ab
to
d6a0d94
Compare
return Object.entries(ContentLevels).map(level => { | ||
let translationKey; | ||
if (level[0] === 'PROFESSIONAL') { | ||
translationKey = 'specializedProfessionalTraining'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @marcellamaki we might want to consolidate this logic somewhere like I think we did on Kolibri?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I stole that from Kolibri: https://github.com/learningequality/kolibri/blob/develop/kolibri/plugins/learn/assets/src/views/EmbeddedSidePanel/SelectGroup.vue#L139
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test could still do more guarantee of behaviour.
Summary
Description of the change(s) you made
Note, this PR does not cover the "Categories" field, and the following issues are to address some specifics with regards to the "Learning Activity" dropdown field and setting defaults based on content kind, which is not covered in this PR.
DetailsTabView
: Set default values on file upload #3373learning_activities
field: Data migration needed for historic data in backend #3374Manual verification steps performed
In the edit modal:
Screenshots
Does this introduce any tech-debt items?
This is a continuation of this issue #3205
Reviewer guidance
How can a reviewer test these changes? Please see Gherkin scenarios for additional, specific user interactions
In the edit modal:
References
Comments
Contributor's Checklist
Studio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)