Fix scope encoding in token requests #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to make it easier to add new tests with different request bodies
The `scope` parameter is not used for the Authorization Code grant. See [RFC 6749 § 4.1.3][spec]. [spec]: https://tools.ietf.org/html/rfc6749#section-4.1.3
cjlarose
commented
Apr 22, 2018
| @@ -1,7 +1,8 @@ | |||
| { | |||
| "rules": { | |||
| "max-len": "off", | |||
| "object-curly-newline": "off" | |||
| "object-curly-newline": "off", | |||
| "func-names": "off" | |||
There was a problem hiding this comment.
I modified a few tests to write shared values to this and removed arrow function literals to do this.
The use of arrow function literals is explicitly discouraged by mocha, but I'm happy to switch the tests back to using block-scoped variables and arrow literals if preferred.
There was a problem hiding this comment.
Hi @cjlarose Sorry for the delay, please revert the mocha test changes related to the arrow functions usage. I am aware of what mocha suggests and open to changes, however in order to make your change easier to merge right now, I need you to restore those changes.
|
Hi, when this PR will be merged? |
|
@jonathansamines Anything I can do to help move this PR along? |
|
Resolved by #200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186