Encode multiple scopes using space instead of comma #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugopeixoto Please base your branch from the develop branch and point your PR to develop. Besides it, LGTM, however will probably schedule this change to v3 because it may break existing users relying on this behavior even though is the wrong one. |
hugopeixoto
force-pushed
the
fix/multiple-scope-encoding
branch
from
79d1392 to
28df029
Compare
|
@jonathansamines Sorry about that, I changed it to develop. |
This was referenced Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec, scopes should be joined using a single space: https://tools.ietf.org/html/rfc6749#appendix-A.4
https://tools.ietf.org/html/rfc6749#section-3.3
This fixes #186 is an alternative to PR #187