-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on empty file upload #21
Comments
@Ezwal Thanks for opening this. I'll take a look asap. |
@Ezwal
Edit: It was easier than I expected. |
Fix #21 - prevent crash on empty payload
Fix published at v0.3.1. Let me know if that solves your issues. Thanks for your help. |
it works fine now, thank you for the very quick response ! |
Using busboy and busboy-body-parser and node major version 7 and above, the application crash when dealing with an empty payload. The error thrown stems from the measure of the piped file buffer length
Buffer.byteLength(d, 'binary')
(index.js l.51).The major change to Buffer break the module since d is an empty array it cause the error :
TypeError: "string" must be a string, Buffer, or ArrayBuffer
. Retrograding works since the line is working before #18The text was updated successfully, but these errors were encountered: